[MDS-5049] TSF view and edit by roles #2830

asinn134 · 2023-11-29T22:06:26Z

Objective

MDS-5049

Adjusted within Core and Minespace the edit of TSF and Dam info to be available if user has core_edit_tsf or mds_minespace_proponents roles
User with the right roles assigned to them can edit or view TSF and Dam info
Changed the TSF and Dam view and edit actions to be in a drop down menu instead of icons

services/core-web/src/components/mine/Tailings/MineTailingsTable.tsx

…nges

asinn134 · 2023-12-01T00:18:05Z

I ended up not moving the tailing files into the common package for this ticket

services/minespace-web/common/components/tailings/AssociatedDams.tsx

services/core-web/common/components/tailings/AssociatedDams.tsx

services/minespace-web/common/components/tailings/AssociatedDams.tsx

services/minespace-web/src/components/dashboard/mine/tailings/TailingsTable.js

matbusby-fw

Looks great! Just added a couple suggestions on importing Icons for better performance. I'm guessing moving these components into the common package just became too much of a can of worms?

matbusby-fw

👍🏻

asinn134 · 2023-12-05T18:27:48Z

Looks great! Just added a couple suggestions on importing Icons for better performance. I'm guessing moving these components into the common package just became too much of a can of worms?

Thanks! yah the moving of the components kind of complicated things, so I ended up just focusing on the story ac for this one.

…/bcgov/mds into mds-5049-tsf-view-and-edit-roles

services/common/src/constants/assets.ts

taraepp · 2023-12-05T21:05:04Z

services/core-web/common/components/tailings/AssociatedDams.tsx

+        icon: <EyeOutlined className="icon-sm padding-sm--right" />,
+        clickFunction: (_event, record) => {
+          handleNavigateToEdit(event, record, (userAction === "edit" ? "editView" : "view"));
+        },


What does editView mean? Seems like it would be simpler to just make it "edit".

Ah editView was setup because we have a scenario where if a user can edit tsf and dams, they will be able to see the edit and view options in the action menu. If the user with edit access clicks on the dam view button, it will bring them to a dam page with all the user inputs disabled. When the user moves back out of the dam page and into the TailingsSummaryPage we still want them to have the ability to edit things. Having the editView helps let us know the user should still be able to edit. Let me know if it doesn't make sense we can talk about it further.

Looks like we are already tracking their permissions on the page that consumes it, so I'm not sure that we need this other variable to also indicate that they should have permission to edit. That userAction still really looks to me like it wants to be a boolean- it is always compared to a string literal. A string constant would be better than a string literal, but a boolean I really think would be best. You're either in view mode or edit mode, and the page itself can track whether the user has permission to change that.

The boolean change has now been applied.

taraepp · 2023-12-05T21:10:04Z

services/core-web/common/components/tailings/TailingsSummaryPage.tsx

+  const [canEditTSF, setCanEditTSF] = useState(false);
+  const { renderConfig, components, routes, isCore } = useContext(TailingsContext);
+  const { Loading } = components;
+  const action = userAction ? userAction : "edit";


set defaults when destructuring props like userAction="edit" on line 86.

This has been adjusted now.

asinn134 added 2 commits November 29, 2023 13:46

setting up role access for tsf view and edit

de5e0fb

Merge branch 'develop' into mds-5049-tsf-view-and-edit-roles

d4ca729

taraepp reviewed Nov 29, 2023

View reviewed changes

services/core-web/src/components/mine/Tailings/MineTailingsTable.tsx Outdated Show resolved Hide resolved

taraepp reviewed Nov 29, 2023

View reviewed changes

services/core-web/src/components/mine/Tailings/MineTailingsTable.tsx Outdated Show resolved Hide resolved

asinn134 added 2 commits November 30, 2023 16:02

change to use renderActionColumns and adjusted minespace to match cha…

2780e3e

…nges

changes to fix redux common error

0a30e98

asinn134 requested review from simensma-fresh, henryoforeh-dev, matbusby-fw, taraepp and isuru-aot December 1, 2023 00:28

taraepp reviewed Dec 1, 2023

View reviewed changes

services/minespace-web/common/components/tailings/AssociatedDams.tsx Outdated Show resolved Hide resolved

matbusby-fw reviewed Dec 1, 2023

View reviewed changes

services/core-web/common/components/tailings/AssociatedDams.tsx Outdated Show resolved Hide resolved

matbusby-fw reviewed Dec 1, 2023

View reviewed changes

services/minespace-web/common/components/tailings/AssociatedDams.tsx Outdated Show resolved Hide resolved

matbusby-fw reviewed Dec 1, 2023

View reviewed changes

services/minespace-web/src/components/dashboard/mine/tailings/TailingsTable.js Outdated Show resolved Hide resolved

matbusby-fw previously approved these changes Dec 1, 2023

View reviewed changes

adjustment to make user that can edit can also view tsf

3953162

asinn134 dismissed matbusby-fw’s stale review via 3953162 December 2, 2023 04:26

asinn134 added 3 commits December 1, 2023 20:31

fix redux common error

52d03c9

small refactor

ac9777f

small refactor

4b8fd4b

matbusby-fw self-requested a review December 4, 2023 23:46

matbusby-fw previously approved these changes Dec 4, 2023

View reviewed changes

Merge branch 'develop' into mds-5049-tsf-view-and-edit-roles

cc6fbaa

asinn134 dismissed matbusby-fw’s stale review via cc6fbaa December 5, 2023 18:12

henryoforeh-dev previously approved these changes Dec 5, 2023

View reviewed changes

asinn134 added 2 commits December 5, 2023 11:24

more adjustments to editing and viewing of dam

e284e50

Merge branch 'mds-5049-tsf-view-and-edit-roles' of https://github.com…

45ae968

…/bcgov/mds into mds-5049-tsf-view-and-edit-roles

asinn134 dismissed henryoforeh-dev’s stale review via 45ae968 December 5, 2023 19:27

asinn134 requested review from taraepp, henryoforeh-dev and matbusby-fw December 5, 2023 19:40

henryoforeh-dev previously approved these changes Dec 5, 2023

View reviewed changes

taraepp reviewed Dec 5, 2023

View reviewed changes

services/common/src/constants/assets.ts Outdated Show resolved Hide resolved

taraepp reviewed Dec 5, 2023

View reviewed changes

addressing pr comments on icons and others

e121e7e

asinn134 dismissed henryoforeh-dev’s stale review via e121e7e December 6, 2023 01:02

asinn134 requested review from taraepp and henryoforeh-dev December 6, 2023 17:31

matbusby-fw previously approved these changes Dec 6, 2023

View reviewed changes

henryoforeh-dev previously approved these changes Dec 6, 2023

View reviewed changes

addressing more pr comments

f2e105a

asinn134 dismissed stale reviews from henryoforeh-dev and matbusby-fw via f2e105a December 7, 2023 00:08

asinn134 added 4 commits December 6, 2023 16:13

fixing redux common error

479a9e3

address unit test error

287df82

adjustments to text

4e8deb9

fixing redux common error

1efdd0c

henryoforeh-dev previously approved these changes Dec 7, 2023

View reviewed changes

change to dam routes

3d4f3ac

asinn134 dismissed henryoforeh-dev’s stale review via 3d4f3ac December 7, 2023 22:47

taraepp approved these changes Dec 7, 2023

View reviewed changes

asinn134 requested review from henryoforeh-dev and matbusby-fw December 7, 2023 22:56

henryoforeh-dev approved these changes Dec 7, 2023

View reviewed changes

asinn134 merged commit c33a8ca into develop Dec 7, 2023
9 checks passed

asinn134 deleted the mds-5049-tsf-view-and-edit-roles branch December 7, 2023 23:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MDS-5049] TSF view and edit by roles #2830

[MDS-5049] TSF view and edit by roles #2830

asinn134 commented Nov 29, 2023 •

edited

Loading

asinn134 commented Dec 1, 2023

matbusby-fw left a comment

matbusby-fw left a comment

asinn134 commented Dec 5, 2023

taraepp Dec 5, 2023

asinn134 Dec 5, 2023 •

edited

Loading

taraepp Dec 6, 2023

asinn134 Dec 7, 2023

taraepp Dec 5, 2023

asinn134 Dec 6, 2023

[MDS-5049] TSF view and edit by roles #2830

[MDS-5049] TSF view and edit by roles #2830

Conversation

asinn134 commented Nov 29, 2023 • edited Loading

Objective

asinn134 commented Dec 1, 2023

matbusby-fw left a comment

Choose a reason for hiding this comment

matbusby-fw left a comment

Choose a reason for hiding this comment

asinn134 commented Dec 5, 2023

taraepp Dec 5, 2023

Choose a reason for hiding this comment

asinn134 Dec 5, 2023 • edited Loading

Choose a reason for hiding this comment

taraepp Dec 6, 2023

Choose a reason for hiding this comment

asinn134 Dec 7, 2023

Choose a reason for hiding this comment

taraepp Dec 5, 2023

Choose a reason for hiding this comment

asinn134 Dec 6, 2023

Choose a reason for hiding this comment

asinn134 commented Nov 29, 2023 •

edited

Loading

asinn134 Dec 5, 2023 •

edited

Loading