Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

237 out-of-memory warnings/solutions #238

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

CeresBarros
Copy link
Member

detection of out-of-memory error when extracting point data from climate rasters + printing a helpful stop message

#237

@CeresBarros CeresBarros requested a review from kdaust April 23, 2024 19:51
@CeresBarros CeresBarros added the enhancement New feature or request label Apr 23, 2024
Copy link
Collaborator

@kdaust kdaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@CeresBarros
Copy link
Member Author

Not sure what's causing failures, but since this was a pretty minor change and we're in devl I'll merge anyways.

@CeresBarros CeresBarros marked this pull request as ready for review April 23, 2024 23:12
@CeresBarros CeresBarros merged commit e251675 into devl Apr 23, 2024
1 of 5 checks passed
@kdaust
Copy link
Collaborator

kdaust commented Apr 24, 2024

Not sure what's causing failures, but since this was a pretty minor change and we're in devl I'll merge anyways.

The fails are on me - I added a new historic observed timeseries (cru + gpcc) last week, but I haven't fully updated all the tests or the vignettes yet. In retrospect I should have made a new branch and done it on there, but I didn't think it would require as many changes as it did. I'll working on fixing that up next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants