-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3594 - Email to Student - 2nd Disbursement has passed, still pending (Part 2) #4303
#3594 - Email to Student - 2nd Disbursement has passed, still pending (Part 2) #4303
Conversation
…ent-has-passed-part-2
sources/packages/backend/apps/queue-consumers/src/services/application/application.service.ts
Outdated
Show resolved
Hide resolved
...vices/student-application-notifications/student-second-disbursement-reminder-notification.ts
Outdated
Show resolved
Hide resolved
...vices/student-application-notifications/student-second-disbursement-reminder-notification.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/queue-consumers/src/services/application/application.service.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/queue-consumers/src/queue-consumers.module.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @lewischen-aot 👍 Left a few comments.
sources/packages/backend/apps/queue-consumers/src/services/application/application.service.ts
Show resolved
Hide resolved
sources/packages/backend/apps/queue-consumers/src/services/application/application.service.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/queue-consumers/src/services/application/application.service.ts
Show resolved
Hide resolved
sources/packages/backend/apps/queue-consumers/src/services/application/application.service.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/queue-consumers/src/services/application/application.service.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/queue-consumers/src/services/application/application.service.ts
Show resolved
Hide resolved
sources/packages/backend/apps/queue-consumers/src/queue-consumers.module.ts
Outdated
Show resolved
Hide resolved
.../schedulers/student-application-notifications/student-application-notifications.scheduler.ts
Outdated
Show resolved
Hide resolved
.../src/services/student-application-notifications/student-application-notifications.service.ts
Outdated
Show resolved
Hide resolved
.../src/services/student-application-notifications/student-application-notifications.service.ts
Outdated
Show resolved
Hide resolved
...umers/src/services/student-application-notifications/student-pd-ppd-reminder-notification.ts
Outdated
Show resolved
Hide resolved
.../src/services/student-application-notifications/student-application-notifications.service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, please take a look at the comments.
* @param processSummary process summary for logging. | ||
*/ | ||
async createNotification(processSummary: ProcessSummary): Promise<void> { | ||
const notificationLog = new ProcessSummary(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
coeStatus: [COEStatus.completed, COEStatus.required], | ||
disbursementScheduleStatusPending: DisbursementScheduleStatus.Pending, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
.innerJoin("assessment.application", "application") | ||
.where(`NOT EXISTS (${notificationExistsQuery})`) | ||
.andWhere("application.applicationStatus = :applicationStatusCompleted") | ||
.andWhere("application.isArchived = false") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @lewischen-aot 👍
sources/packages/backend/apps/queue-consumers/src/services/application/application.service.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/queue-consumers/src/services/application/application.service.ts
Show resolved
Hide resolved
sources/packages/backend/apps/queue-consumers/src/services/application/application.service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes, especially by putting the effort into the SQL query. Please take a look at the remaining comments.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes and looking into the query. Looks good 👍
As the second part of the story, this PR has the following changes
COUNT(assessment.id)
to differentiate 2-disbursements applications from 1-disbursement applications."pending""required".Screenshot of the notification email

SQL version of the query as a reference