Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3498 - Content: Ministry: Change request approve/deny #4277

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

bidyashish
Copy link
Collaborator

As a ministry user I want clear instructions so I can adjudicate student change requests.

Acceptance Criteria

  • When a ministry user selects a student change request, they are brought to this page for the approval/denial process.
  • Revise: "View request" to "View request(s)"
  • Revise: "Student change" to "Student change requests"
  • Display bulleted points that advises the following:

"Instructions:

  • View the change request and any supporting documentation on the student application

  • Review the history of Request a Change submissions prior to approving each new one to ensure
    continuity

  • Review all fields to ensure that information is consistent with the students current circumstances

  • When the review is complete, come back to this page to approve or deny the request"

  • For AC above see ticket 3496 for text placement.

  • Revise: "Staff area" to "Decision"

Note: For Instructions placement, it needs to after header, since there are multiple forms json added in Vue file to common share.
image

@bidyashish bidyashish added Ministry Ministry Features Form.io Form IO definitions changed. labels Jan 22, 2025
@bidyashish bidyashish self-assigned this Jan 22, 2025
@dheepak-aot dheepak-aot self-requested a review January 22, 2025 20:01
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.52% ( 3864 / 17159 )
Methods: 10.32% ( 224 / 2170 )
Lines: 25.93% ( 3336 / 12866 )
Branches: 14.32% ( 304 / 2123 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.14% ( 1249 / 1450 )
Methods: 82.42% ( 136 / 165 )
Lines: 88.51% ( 1032 / 1166 )
Branches: 68.07% ( 81 / 119 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 68.11% ( 6019 / 8837 )
Methods: 65.84% ( 742 / 1127 )
Lines: 71.94% ( 4712 / 6550 )
Branches: 48.71% ( 565 / 1160 )

@lewischen-aot lewischen-aot self-requested a review January 22, 2025 21:38
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes @bidyashish. Looks good 👍

Copy link
Collaborator

@lewischen-aot lewischen-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice work @bidyashish

@bidyashish bidyashish added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 19bc83d Jan 22, 2025
21 checks passed
@bidyashish bidyashish deleted the feature/#3498-content-change-request branch January 22, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Form.io Form IO definitions changed. Ministry Ministry Features Web portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants