#3313 - Content: Ministry: Accounts #4269
Conversation
lewischen-aot
added
User Story
Ministry
sources/packages/web/src/views/aest/student/StudentAccountApplications.vue
Show resolved
Hide resolved
| return this.repo | ||
| .createQueryBuilder("studentAccountApplication") | ||
| .select("studentAccountApplication.id", "id") | ||
| .addSelect("studentAccountApplication.submittedDate", "submittedDate") | ||
| .addSelect("user.firstName", "givenNames") | ||
| .addSelect("user.lastName", "lastName") | ||
| .addSelect("student.birthDate", "birthDate") | ||
| .innerJoin("studentAccountApplication.user", "user") | ||
| .leftJoin(Student, "student", "student.user.id = user.id") | ||
| .where("studentAccountApplication.assessedDate is NULL") | ||
| .orderBy("studentAccountApplication.submittedDate", "ASC") | ||
| .getRawMany(); |
There was a problem hiding this comment.
Unless there is a strong reason, the preferred way would be to use the object query. Was there a reason to switch the query format?
There was a problem hiding this comment.
The reason is that we need to get birth date for a student record from the student table, and the origin query doesn't support the relation from user to student. The leftJoin(Student, ...) in this object query allows to get the birth date.
There was a problem hiding this comment.
The student may not exist at this stage because it will be created after the Ministry's approval.
The birth date for this case should come from the submitted_data->>dateOfBirth.
...src/route-controllers/student-account-applications/models/student-account-application.dto.ts
Outdated
Show resolved
Hide resolved
...nd/apps/api/src/services/student-account-applications/student-account-applications.models.ts
Outdated
Show resolved
Hide resolved
sources/packages/web/src/views/aest/student/StudentAccountApplications.vue
Outdated
Show resolved
Hide resolved
| fullName: getUserFullName(accountApplication.user), | ||
| submittedDate: accountApplication.submittedDate, | ||
| })); | ||
| return accountApplications; |
There was a problem hiding this comment.
The map must happen for every DTO conversion to avoid changes at the service level to expose unwanted properties. Please add the map back.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Screenshot of the updated page
