Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3054 - Email notification for blocked disbursement to ministry only once - Change log hierarchy #4259

Merged

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Jan 16, 2025

The blocked notifications logs were using the parent log instead of the child log some hierarchy was added now as below. This was an existing issue and it was causing multiple logs from multiple children to be appended to the same hierarchy.

Log sample with the new hierarchy

INFO: Executing e-Cert calculations for all eligible disbursements.'
INFO: Retrieving eligible disbursements(s).'
INFO: Found 1 eligible disbursement(s) for 1 student(s).'
--INFO: Log details'
--INFO: Processing application number 5906924436, disbursement id 41 scheduled for 2025-01-16.'
----INFO: Log details'
----INFO: Executing e-Cert calculation steps.'
----INFO: Executing step 1 out of 9.'
----INFO: Executing full-time disbursement validations.'
----INFO: Disbursement estimated awards do not contain any amount to be disbursed.'
----INFO: There are no active restriction bypasses.'
----INFO: Checking if blocked disbursement notifications should be generated.'
------INFO: Log details'
------INFO: Ministry Blocked Disbursement notification should not be created at this moment for disbursement ID 41.'
------INFO: Log details'
------INFO: Student Blocked Disbursement notification created for disbursement ID 41.'
--INFO: The step determined that the calculation should be interrupted. This disbursement will not be part of the next e-Cert generation.'
INFO: Sending e-Cert file.'
INFO: Retrieving Full Time disbursements to generate the e-Cert file...'
INFO: Found 0 Full Time disbursements schedules.'
INFO: Creating Full Time e-Cert file content...'
INFO: Uploading Full Time content...'
INFO: Generated file: MSFT-Request\\DPBC.EDU.FTECERTS.20250116.001'

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.51% ( 3864 / 17162 )
Methods: 10.33% ( 224 / 2169 )
Lines: 25.92% ( 3336 / 12869 )
Branches: 14.31% ( 304 / 2124 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.14% ( 1249 / 1450 )
Methods: 82.42% ( 136 / 165 )
Lines: 88.51% ( 1032 / 1166 )
Branches: 68.07% ( 81 / 119 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.77% ( 5994 / 8844 )
Methods: 65.57% ( 739 / 1127 )
Lines: 71.63% ( 4696 / 6556 )
Branches: 48.15% ( 559 / 1161 )

@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review January 17, 2025 00:10
await this.eCertNotificationService.notifyBlockedDisbursement(
eCertDisbursement,
entityManager,
parentLog,
stepsLog,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is where the parentLog was incorrectly being used and causing logs from different parents to be together.

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @andrewsignori-aot

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ad-hoc Bug Something isn't working Queue Consumers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants