-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3054 - Email notification for blocked disbursement to ministry only once - Change log hierarchy #4259
#3054 - Email notification for blocked disbursement to ministry only once - Change log hierarchy #4259
Conversation
Quality Gate passedIssues Measures |
await this.eCertNotificationService.notifyBlockedDisbursement( | ||
eCertDisbursement, | ||
entityManager, | ||
parentLog, | ||
stepsLog, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is where the parentLog
was incorrectly being used and causing logs from different parents to be together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @andrewsignori-aot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
The blocked notifications logs were using the parent log instead of the child log some hierarchy was added now as below. This was an existing issue and it was causing multiple logs from multiple children to be appended to the same hierarchy.
Log sample with the new hierarchy