[api][web][sims-120] Add institution location form and API to save the data to sims data base after form validation #425
Conversation
…save the data to sims data base after form validation
ann-aot
changed the title
| @@ -16,3 +16,4 @@ COMMENT ON TABLE institutions_users IS 'This is a pivot table to capture the rel | |||
| COMMENT ON COLUMN institutions_users.id IS 'Auto-generated sequential primary key column'; | |||
| COMMENT ON COLUMN institutions_users.user_id IS 'Foreign key reference to users table users'; | |||
| COMMENT ON COLUMN institutions_users.institution_id IS 'Foreign key reference to users table institutions'; | |||
| 1 | |||
There was a problem hiding this comment.
Please consider not including this file in the PR if the only change is the line break.
| @@ -29,7 +29,6 @@ export default { | |||
| const formDefinition = await ApiClient.DynamicForms.getFormDefinition( | |||
| props.formName, | |||
| ); | |||
There was a problem hiding this comment.
Please consider not including this file in the PR if the only change is the line break.
| locationName: string; | ||
| postalZipCode: string; | ||
| provinceState: string; | ||
| submit: boolean; |
There was a problem hiding this comment.
Please consider removing the submit from here since it is not part of the business model.
There was a problem hiding this comment.
okay, at any point we won't be using the submit variable right? okay I will remove it
| locationName: string; | ||
| postalZipCode: string; | ||
| provinceState: string; | ||
| submit: boolean; |
There was a problem hiding this comment.
Please consider removing the submit from here since it is not part of the business model.
| async create( | ||
| @Body() payload: InstitutionLocationType, | ||
| @UserToken() userToken: IUserToken, | ||
| ): Promise<GetInstitutionLocationDto> { |
There was a problem hiding this comment.
I believe that this method should return a Promise since it is returning only the id.
|
|
||
| @Post() | ||
| async create( | ||
| @Body() payload: InstitutionLocationType, |
There was a problem hiding this comment.
We are trying to keep all objects received/returned by the API as DTO. I would recommend moving this to the DTO level.
…form and API to save the data to sims data base after form validation
| provinceState: string, | ||
| postalZipCode: string, | ||
| country: string, | ||
| applicationId: string, |
There was a problem hiding this comment.
Is there any particular reason these properties be present here?
- applicationId: string,
- pid: string,
- process_pid: string
… added and unused variable removed
…save the data to sims data base after form validation