Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3792 - Student: FT Residency exception for dependant students #4249

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Jan 15, 2025

  • Changed application questions order on the Personal Information tab;
    image

  • Moved the dependantStatus hidden component to Personal information tab:

  • Added condition to display Residency information section when user is considered "independant":

    • Student is asked for parent information if:
     data.hasDependents === "no" &&
     data.relationshipStatus === "single" &&
     data.outOfHighSchoolFor4Years === "no" &&
     data.howWillYouBeAttendingTheProgram === "Full Time" &&
     data.custodyOfChildWelfare !== "yes"
    • Student is considered independant for Full-time if:
    data.showParentInformation &&
    (data.parentbcResident === "bothOfMyHaveParentsHavePassedAwayAndIHaveNoLegalGuardian" || 
      data.parentbcResident === "estranged")
  • Part-time application will always show BC Residency section.

@andrepestana-aot andrepestana-aot self-assigned this Jan 15, 2025
@andrepestana-aot andrepestana-aot added Student Student Features Form.io Form IO definitions changed. labels Jan 15, 2025
@andrepestana-aot andrepestana-aot marked this pull request as ready for review January 15, 2025 23:57
@andrewsignori-aot andrewsignori-aot self-requested a review January 15, 2025 23:58
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please have a look on the PT show comment.

…ime when all the fields are populated and student considered independant
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.52% ( 3864 / 17158 )
Methods: 10.33% ( 224 / 2169 )
Lines: 25.93% ( 3336 / 12865 )
Branches: 14.31% ( 304 / 2124 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.14% ( 1249 / 1450 )
Methods: 82.42% ( 136 / 165 )
Lines: 88.51% ( 1032 / 1166 )
Branches: 68.07% ( 81 / 119 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.77% ( 5994 / 8844 )
Methods: 65.57% ( 739 / 1127 )
Lines: 71.63% ( 4696 / 6556 )
Branches: 48.15% ( 559 / 1161 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes, looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Form.io Form IO definitions changed. Student Student Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants