Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4024 - SFAS to SIMS Bridge - CSL/BCSL Overawards - PR 1 #4239

Merged

Conversation

lewischen-aot
Copy link
Collaborator

@lewischen-aot lewischen-aot commented Jan 14, 2025

  • Adjusted the current import fields to read the right fixed position for the two fields.
  • Created a DB migration to swap the columns to allow the switch of their values.
  • Adjusted E2E tests for the new field.

Rollback evidence

image

Screenshot of the column values before and after the swap script
image

@lewischen-aot lewischen-aot marked this pull request as ready for review January 15, 2025 00:00
@andrewsignori-aot andrewsignori-aot self-requested a review January 15, 2025 17:25
sims.sfas_individuals
SET
csl_overaward = bcsl_overaward,
bcsl_overaward = csl_overaward;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sonar is complaining about the "where" clause. Maybe adding: "WHERE 1=1" would solve it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change the code. I resolved the sonar cloud issue. In this case, it is a false positive since we want the query to be executed without a where clause.

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution to achieve the swap of the columns and values. Just a minor comment, hence approving it, looks good 👍

Just to double-check, the below AC will be executed in an upcoming PR?

Create a DB migration to delete the records from the sims.disbursement_overawards where the origin type is Legacy overaward.

@lewischen-aot
Copy link
Collaborator Author

Great solution to achieve the swap of the columns and values. Just a minor comment, hence approving it, looks good 👍

Just to double-check, the below AC will be executed in an upcoming PR?

Create a DB migration to delete the records from the sims.disbursement_overawards where the origin type is Legacy overaward.

Yes, that's right. The upcoming PR will have this DB migration.

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.48% ( 3850 / 17124 )
Methods: 10.36% ( 224 / 2162 )
Lines: 25.88% ( 3322 / 12838 )
Branches: 14.31% ( 304 / 2124 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.14% ( 1249 / 1450 )
Methods: 82.42% ( 136 / 165 )
Lines: 88.51% ( 1032 / 1166 )
Branches: 68.07% ( 81 / 119 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.77% ( 5994 / 8844 )
Methods: 65.57% ( 739 / 1127 )
Lines: 71.63% ( 4696 / 6556 )
Branches: 48.15% ( 559 / 1161 )

csl_overaward = bcsl_overaward,
bcsl_overaward = csl_overaward;

COMMENT ON COLUMN sims.sfas_individuals.csl_overaward IS 'Canada Student Loan total overaward balance (overaward_balance.overaward_balance_amt, overaward_balance_cde = "CSL").';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the SQL also ❤️

@lewischen-aot lewischen-aot added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 5a0c319 Jan 15, 2025
21 checks passed
@lewischen-aot lewischen-aot deleted the feature/#4024-sfas-sims-bridge-csl-bcsl-overawards branch January 15, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants