#4024 - SFAS to SIMS Bridge - CSL/BCSL Overawards - PR 1 #4239
Conversation
lewischen-aot
added
Queue Consumers
E2E/Unit tests
DB
...packages/backend/apps/db-migrations/src/sql/SFASIndividuals/Update-swap-csl-bcsl-columns.sql
Show resolved
Hide resolved
| sims.sfas_individuals | ||
| SET | ||
| csl_overaward = bcsl_overaward, | ||
| bcsl_overaward = csl_overaward; |
There was a problem hiding this comment.
Sonar is complaining about the "where" clause. Maybe adding: "WHERE 1=1" would solve it.
There was a problem hiding this comment.
Please do not change the code. I resolved the sonar cloud issue. In this case, it is a false positive since we want the query to be executed without a where clause.
...packages/backend/libs/integrations/src/sfas-integration/sfas-files/sfas-individual-record.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Great solution to achieve the swap of the columns and values. Just a minor comment, hence approving it, looks good 👍
Just to double-check, the below AC will be executed in an upcoming PR?
Create a DB migration to delete the records from the sims.disbursement_overawards where the origin type is Legacy overaward.
Yes, that's right. The upcoming PR will have this DB migration. |
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
| csl_overaward = bcsl_overaward, | ||
| bcsl_overaward = csl_overaward; | ||
|
|
||
| COMMENT ON COLUMN sims.sfas_individuals.csl_overaward IS 'Canada Student Loan total overaward balance (overaward_balance.overaward_balance_amt, overaward_balance_cde = "CSL").'; |
There was a problem hiding this comment.
Thanks for fixing the SQL also ❤️
lewischen-aot
deleted the
feature/#4024-sfas-sims-bridge-csl-bcsl-overawards
branch
Rollback evidence
Screenshot of the column values before and after the swap script
