-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4024 - SFAS to SIMS Bridge - CSL/BCSL Overawards - PR 1 #4239
#4024 - SFAS to SIMS Bridge - CSL/BCSL Overawards - PR 1 #4239
Conversation
...packages/backend/apps/db-migrations/src/sql/SFASIndividuals/Update-swap-csl-bcsl-columns.sql
Show resolved
Hide resolved
sims.sfas_individuals | ||
SET | ||
csl_overaward = bcsl_overaward, | ||
bcsl_overaward = csl_overaward; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sonar is complaining about the "where" clause. Maybe adding: "WHERE 1=1" would solve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not change the code. I resolved the sonar cloud issue. In this case, it is a false positive since we want the query to be executed without a where clause.
...packages/backend/libs/integrations/src/sfas-integration/sfas-files/sfas-individual-record.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great solution to achieve the swap of the columns and values. Just a minor comment, hence approving it, looks good 👍
Just to double-check, the below AC will be executed in an upcoming PR?
Create a DB migration to delete the records from the sims.disbursement_overawards where the origin type is Legacy overaward.
Yes, that's right. The upcoming PR will have this DB migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
csl_overaward = bcsl_overaward, | ||
bcsl_overaward = csl_overaward; | ||
|
||
COMMENT ON COLUMN sims.sfas_individuals.csl_overaward IS 'Canada Student Loan total overaward balance (overaward_balance.overaward_balance_amt, overaward_balance_cde = "CSL").'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the SQL also ❤️
Rollback evidence
Screenshot of the column values before and after the swap script
