#3666 - Queue Monitoring - Sysdig Team Update #4233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
bidyashish
reviewed
Jan 14, 2025
guru-aot
reviewed
Jan 14, 2025
| @@ -517,3 +517,11 @@ deploy-forms: | |||
| delete-redis: | |||
| @echo "+\n++ Removing redis and resources on $(NAMESPACE)\n+" | |||
| @oc delete -n $(NAMESPACE) all,rc,svc,dc,route,pvc,secret,configmap,sa -l app=redis | |||
|
|
|||
| update-sysdig-team: | |||
| @echo "Updating Sysdig Team for license plate 0c27fb.\n" | |||
dheepak-aot
approved these changes
Jan 14, 2025
guru-aot
reviewed
Jan 14, 2025
| role: ROLE_TEAM_STANDARD | ||
| - name: [email protected] | ||
| role: ROLE_TEAM_STANDARD | ||
| apiVersion: template.openshift.io/v1 |
There was a problem hiding this comment.
did we update the kind to template from the SysdigTeam ?
as per the documentation of bcgov devops, its been created, anything changed other than the ${LICENSE_PLATE} parameter addition?
I believe if that is the case, we can have 2 sysdig-0c27fb-team.yml and sysdig-a6ef19-team.yml
There was a problem hiding this comment.
The file did not use a template before. I converted it to a template to allow the parameter to be added. The sysdig object should be exactly the same as before: ops.gov.bc.ca/v1alpha1. Am I missing something?
guru-aot
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket is to add missing team members to the sysdig as agreed during the development of the ticket #3666.
Please note the ticket is not associated with the PR because it is closed and does not seem worth opening or creating a ticket only for this task.
The current way to update and apply the changes was manual and demanded manual editing of the file to be applied to each license plate. The intention of this PR is to make it simple.
Technical documentation about Sysdig team setup: https://developer.gov.bc.ca/docs/default/component/platform-developer-docs/docs/app-monitoring/sysdig-monitor-setup-team/?utm_source=digital&utm_medium=web&utm_campaign=sysdig-monitor