#4155 - Disbursement Receipt Process - Expectations on Fail #4232

guru-aot · 2025-01-14T04:50:14Z

Rollback change migration screenshot
REPORT change to generate the zero record CSV.

CRON change for queue-configuration.

E2E test cases added and updated the existing e2e.

…ail_Expectations

...packages/backend/apps/db-migrations/src/sql/Queue/Update-disbursement-receipts-file-cron.sql

sh16011993 · 2025-01-15T17:07:40Z

...backend/apps/db-migrations/src/sql/Queue/Rollback-update-disbursement-receipts-file-cron.sql

@@ -0,0 +1,11 @@
+update


Should we do these keywords in uppercase? For other places and files too.

Are we following this in our PRs?

From my previous understanding, I don't think that we are using lowercase for keywords anywhere.

sh16011993 · 2025-01-15T17:20:29Z

...esdc-integration/disbursement-receipt-integration/disbursement-receipt.processing.service.ts

@@ -62,6 +62,13 @@ export class DisbursementReceiptProcessingService {
      this.esdcConfig.ftpResponseFolder,
      fileSearch,
    );
+    // Throw an error if there are no files to be processed.
+    if (filePaths.length === 0) {
+      processSummary.error(


...esdc-integration/disbursement-receipt-integration/disbursement-receipt.processing.service.ts

sh16011993 · 2025-01-15T20:39:56Z

...s/backend/apps/db-migrations/src/sql/Reports/Update-daily-disbursement-file-zero-records.sql

+                SELECT
+                    1
+                FROM
+                    disbursement_receipt_dataset


Shouldn't the FROM be disbursement_receipts.

Currently, disbursement_receipt_dataset also works since the where conditions are the same but in future if the where conditions inside the inner select statement changes, the inner query might not return any data and therefore, if that happens, we will have to add the empty record line as expected by the business but as per the current logic it won't get added.

Just a suggestion to change it to disbursement_receipts.

It should be from the disbursement_receipt_dataset as we are trying to provide a default record when the dataset is empty.

@dheepak-aot Right now the where conditions in the view selected at the top via disbursement_receipt_dataset and the SELECT immediately below it are the same. In future, it might very well happen that the SELECT has a different WHERE condition which results in removing everything from the above selected view. If this happens, we will have to add the empty record line as expected by the business but as per the current logic it won't get added.

...ntegration/ecert-integration/_tests_/disbursement-receipts-integration.scheduler.e2e-spec.ts

...s/backend/apps/db-migrations/src/sql/Reports/Update-daily-disbursement-file-zero-records.sql

...ntegration/ecert-integration/_tests_/disbursement-receipts-integration.scheduler.e2e-spec.ts

sh16011993

Nice work @guru-aot . Left a few comments.

...ntegration/ecert-integration/_tests_/disbursement-receipts-integration.scheduler.e2e-spec.ts

dheepak-aot · 2025-01-15T21:45:24Z

...ntegration/ecert-integration/_tests_/disbursement-receipts-integration.scheduler.e2e-spec.ts

+      expect(fileContent).toContain(
+        "Full Time BC Student Loan,Full Time BC Student Grant,Full Time BC Total,Part Time BC Student Grant,Part Time BC Total,BC Total,Total Records,File Date,Batch Run Date,Sequence Number",
+      );
+      expect(fileContent).toContain("0,0,0,0,0,0,0,2024-01-31,,3228");


The date and sequence number can be used a constant so that it can be used across many tests in the file.

Please use the constant that is already defined.

I believe it is from existing code.

dheepak-aot · 2025-01-15T21:46:41Z

...ntegration/ecert-integration/_tests_/disbursement-receipts-integration.scheduler.e2e-spec.ts

+      const createdNotification = await db.notification.findOne({
+        select: {
+          id: true,
+          dateSent: true,
+          messagePayload: true,
+          notificationMessage: { id: true, templateId: true },
+        },
+        relations: { notificationMessage: true },
+        where: {
+          dateSent: IsNull(),
+          notificationMessage: {
+            id: NotificationMessageType.MinistryNotificationProvincialDailyDisbursementReceipt,
+          },
+        },
+      });


Minor and not blocker. I see this code repeating a lot. We can create a common function and re-use.

will do as part of another effort

...esdc-integration/disbursement-receipt-integration/disbursement-receipt.processing.service.ts

dheepak-aot · 2025-01-15T21:54:43Z

...s/backend/apps/db-migrations/src/sql/Reports/Update-daily-disbursement-file-zero-records.sql

+        UNION
+        ALL 


While setting a default record on result set being empty UNION vs UNION ALL does not make any difference and UNION is more accurate here. But I won't consider it as blocker.

dheepak-aot · 2025-01-15T21:55:36Z

Great work @guru-aot. Please have a look at the comments.

...s/backend/apps/db-migrations/src/sql/Reports/Update-daily-disbursement-file-zero-records.sql

dheepak-aot

Thanks for doing the changes. Looks good 👍

sonarqubecloud · 2025-01-16T01:37:45Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-01-16T01:38:46Z

Backend Unit Tests Coverage Report

Totals
Statements:	22.52% ( 3864 / 17158 )
Methods:	10.33% ( 224 / 2169 )
Lines:	25.93% ( 3336 / 12865 )
Branches:	14.31% ( 304 / 2124 )

github-actions · 2025-01-16T01:39:04Z

E2E Workflow Workers Coverage Report

Totals
Statements:	65.59% ( 589 / 898 )
Methods:	59.63% ( 65 / 109 )
Lines:	68.72% ( 468 / 681 )
Branches:	51.85% ( 56 / 108 )

github-actions · 2025-01-16T01:41:28Z

E2E Queue Consumers Coverage Report

Totals
Statements:	86.14% ( 1249 / 1450 )
Methods:	82.42% ( 136 / 165 )
Lines:	88.51% ( 1032 / 1166 )
Branches:	68.07% ( 81 / 119 )

github-actions · 2025-01-16T01:44:02Z

E2E SIMS API Coverage Report

Totals
Statements:	67.77% ( 5994 / 8844 )
Methods:	65.57% ( 739 / 1127 )
Lines:	71.63% ( 4696 / 6556 )
Branches:	48.15% ( 559 / 1161 )

sh16011993

Great work @guru-aot 👍

Initial commit

97a3abf

guru-aot self-assigned this Jan 14, 2025

Cron update

1472222

guru-aot added the DB DB migration involved label Jan 14, 2025

guru-aot added 4 commits January 14, 2025 21:12

updated

5e37c4a

updated

50a5754

E2E

8c3a935

updated

53295a8

guru-aot marked this pull request as ready for review January 14, 2025 23:11

guru-aot added 3 commits January 14, 2025 23:16

updated

0ebc6a8

Merge branch 'main' into feature/#4155-Disbursement_Receipt_Process_F…

6a72970

…ail_Expectations

updated

287bade

guru-aot added the E2E/Unit tests label Jan 15, 2025

dheepak-aot self-requested a review January 15, 2025 16:46

dheepak-aot reviewed Jan 15, 2025

View reviewed changes

...packages/backend/apps/db-migrations/src/sql/Queue/Update-disbursement-receipts-file-cron.sql Outdated Show resolved Hide resolved

dheepak-aot added Queue Consumers Integration labels Jan 15, 2025

updated

5bcb3d2

sh16011993 reviewed Jan 15, 2025

View reviewed changes

...esdc-integration/disbursement-receipt-integration/disbursement-receipt.processing.service.ts Show resolved Hide resolved

sh16011993 reviewed Jan 15, 2025

View reviewed changes

...ntegration/ecert-integration/_tests_/disbursement-receipts-integration.scheduler.e2e-spec.ts Outdated Show resolved Hide resolved

sh16011993 reviewed Jan 15, 2025

View reviewed changes

...ntegration/ecert-integration/_tests_/disbursement-receipts-integration.scheduler.e2e-spec.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Jan 15, 2025

View reviewed changes

...s/backend/apps/db-migrations/src/sql/Reports/Update-daily-disbursement-file-zero-records.sql Outdated Show resolved Hide resolved

dheepak-aot reviewed Jan 15, 2025

View reviewed changes

...s/backend/apps/db-migrations/src/sql/Reports/Update-daily-disbursement-file-zero-records.sql Outdated Show resolved Hide resolved

updated

e33b29c

dheepak-aot reviewed Jan 15, 2025

View reviewed changes

...ntegration/ecert-integration/_tests_/disbursement-receipts-integration.scheduler.e2e-spec.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Jan 15, 2025

View reviewed changes

...ntegration/ecert-integration/_tests_/disbursement-receipts-integration.scheduler.e2e-spec.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Jan 15, 2025

View reviewed changes

...ntegration/ecert-integration/_tests_/disbursement-receipts-integration.scheduler.e2e-spec.ts Show resolved Hide resolved

sh16011993 reviewed Jan 15, 2025

View reviewed changes

dheepak-aot reviewed Jan 15, 2025

View reviewed changes

...ntegration/ecert-integration/_tests_/disbursement-receipts-integration.scheduler.e2e-spec.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Jan 15, 2025

View reviewed changes

...esdc-integration/disbursement-receipt-integration/disbursement-receipt.processing.service.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Jan 15, 2025

View reviewed changes

guru-aot added 2 commits January 15, 2025 23:04

updated

7891b58

updated

56268b1

dheepak-aot reviewed Jan 15, 2025

View reviewed changes

...s/backend/apps/db-migrations/src/sql/Reports/Update-daily-disbursement-file-zero-records.sql Outdated Show resolved Hide resolved

updated

825aa8b

dheepak-aot approved these changes Jan 15, 2025

View reviewed changes

updated

52d8f81

sh16011993 approved these changes Jan 16, 2025

View reviewed changes

guru-aot added this pull request to the merge queue Jan 16, 2025

Merged via the queue into main with commit ce07ef1 Jan 16, 2025
21 checks passed

guru-aot deleted the feature/#4155-Disbursement_Receipt_Process_Fail_Expectations branch January 16, 2025 17:48

guru-aot temporarily deployed to DEV January 16, 2025 17:58 — with GitHub Actions Inactive

guru-aot temporarily deployed to DEV January 16, 2025 17:59 — with GitHub Actions Inactive

guru-aot temporarily deployed to DEV January 16, 2025 18:01 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#4155 - Disbursement Receipt Process - Expectations on Fail #4232

#4155 - Disbursement Receipt Process - Expectations on Fail #4232

guru-aot commented Jan 14, 2025 •

edited

Loading

sh16011993 Jan 15, 2025 •

edited

Loading

guru-aot Jan 15, 2025

sh16011993 Jan 15, 2025

sh16011993 Jan 15, 2025

sh16011993 Jan 15, 2025 •

edited

Loading

dheepak-aot Jan 15, 2025

sh16011993 Jan 15, 2025

sh16011993 left a comment

dheepak-aot Jan 15, 2025

dheepak-aot Jan 15, 2025

guru-aot Jan 15, 2025

dheepak-aot Jan 15, 2025

guru-aot Jan 15, 2025

dheepak-aot Jan 15, 2025

dheepak-aot commented Jan 15, 2025

dheepak-aot left a comment

sonarqubecloud bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

sh16011993 left a comment

#4155 - Disbursement Receipt Process - Expectations on Fail #4232

#4155 - Disbursement Receipt Process - Expectations on Fail #4232

Conversation

guru-aot commented Jan 14, 2025 • edited Loading

sh16011993 Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sh16011993 Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sh16011993 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dheepak-aot commented Jan 15, 2025

dheepak-aot left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 16, 2025

Quality Gate passed

github-actions bot commented Jan 16, 2025

Backend Unit Tests Coverage Report

github-actions bot commented Jan 16, 2025

E2E Workflow Workers Coverage Report

github-actions bot commented Jan 16, 2025

E2E Queue Consumers Coverage Report

github-actions bot commented Jan 16, 2025

E2E SIMS API Coverage Report

sh16011993 left a comment

Choose a reason for hiding this comment

guru-aot commented Jan 14, 2025 •

edited

Loading

sh16011993 Jan 15, 2025 •

edited

Loading

sh16011993 Jan 15, 2025 •

edited

Loading