Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2370 - Institution Read-Only User Type - PR 3 #4228

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

andrepestana-aot
Copy link
Collaborator

  • Added access to read-only user to institution routes

@andrepestana-aot andrepestana-aot self-assigned this Jan 13, 2025
@andrepestana-aot andrepestana-aot marked this pull request as ready for review January 13, 2025 22:41
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.22% ( 3787 / 17042 )
Methods: 10.17% ( 219 / 2154 )
Lines: 25.67% ( 3282 / 12785 )
Branches: 13.6% ( 286 / 2103 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, look good 👍

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.14% ( 1249 / 1450 )
Methods: 82.42% ( 136 / 165 )
Lines: 88.51% ( 1032 / 1166 )
Branches: 68.07% ( 81 / 119 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.58% ( 5960 / 8819 )
Methods: 65.3% ( 734 / 1124 )
Lines: 71.48% ( 4674 / 6539 )
Branches: 47.75% ( 552 / 1156 )

Copy link
Collaborator

@lewischen-aot lewischen-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Institution Institution Features Web portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants