#3965 - Separate Sequencing for FT and PT eCert Numbers

sources/packages/backend/apps/api/src/route-controllers/confirmation-of-enrollment/_tests_/e2e/confirmation-of-enrollment.institutions.confirmEnrollment.e2e-spec.ts

@@ -23,6 +23,7 @@ import {
   EducationProgramOffering,
   Institution,
   InstitutionLocation,
+  OfferingIntensity,
 } from "@sims/sims-db";
 import { MONEY_VALUE_FOR_UNKNOWN_MAX_VALUE } from "../../../../utilities";
 import { COE_WINDOW, addDays, getISODateOnlyString } from "@sims/utilities";
@@ -89,6 +90,41 @@ describe("ConfirmationOfEnrollmentInstitutionsController(e2e)-confirmEnrollment"
     );
   });
 
+  it("Should allow the COE confirmation when the application is on Enrolment status and all the conditions are fulfilled for Part Time offering.", async () => {
+    // Arrange
+    const application = await saveFakeApplicationDisbursements(
+      appDataSource,
+      {
+        institution: collegeC,
+        institutionLocation: collegeCLocation,
+      },
+      {
+        applicationStatus: ApplicationStatus.Enrolment,
+        offeringIntensity: OfferingIntensity.partTime,
+      },
+    );
+    const [firstDisbursementSchedule] =
+      application.currentAssessment.disbursementSchedules;
+    const endpoint = `/institutions/location/${collegeCLocation.id}/confirmation-of-enrollment/disbursement-schedule/${firstDisbursementSchedule.id}/confirm`;
+    // Act/Assert
+    await request(app.getHttpServer())
+      .patch(endpoint)
+      .send({ tuitionRemittanceAmount: 1 })
+      .auth(
+        await getInstitutionToken(InstitutionTokenTypes.CollegeCUser),
+        BEARER_AUTH_TYPE,
+      )
+      .expect(HttpStatus.OK);
+    // Check if the application was updated as expected.
+    const updatedApplication = await applicationRepo.findOne({
+      select: { applicationStatus: true },
+      where: { id: application.id },
+    });
+    expect(updatedApplication.applicationStatus).toBe(
+      ApplicationStatus.Completed,
+    );
+  });
+
   it("Should allow the second COE confirmation when the application is on Completed status and all the conditions are fulfilled.", async () => {
     // Arrange
     const application = await saveFakeApplicationDisbursements(

sources/packages/backend/apps/db-migrations/src/migrations/1736193026064-RenameSequenceNameDocumentNumber.ts

@@ -0,0 +1,18 @@
+import { MigrationInterface, QueryRunner } from "typeorm";
+import { getSQLFileData } from "../utilities/sqlLoader";
+
+export class RenameSequenceNameDocumentNumber1736193026064
+  implements MigrationInterface
+{
+  public async up(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(
+      getSQLFileData("Rename-sequence-name.sql", "SequenceControl"),
+    );
+  }
+
+  public async down(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(
+      getSQLFileData("Rollback-rename-sequence-name.sql", "SequenceControl"),
+    );
+  }
+}

sources/packages/backend/apps/db-migrations/src/sql/SequenceControl/Rename-sequence-name.sql

@@ -0,0 +1,3 @@
+UPDATE sims.sequence_controls
+SET sequence_name = 'Part Time_DISBURSEMENT_DOCUMENT_NUMBER'::varchar(100)
+WHERE sequence_name = 'DISBURSEMENT_DOCUMENT_NUMBER'::varchar(100);

sources/packages/backend/apps/db-migrations/src/sql/SequenceControl/Rollback-rename-sequence-name.sql

@@ -0,0 +1,3 @@
+UPDATE sims.sequence_controls
+SET sequence_name = 'DISBURSEMENT_DOCUMENT_NUMBER'::varchar(100)
+WHERE sequence_name = 'Part Time_DISBURSEMENT_DOCUMENT_NUMBER'::varchar(100);

sources/packages/backend/libs/services/src/confirmation-of-enrollment/confirmation-of-enrollment.service.ts

@@ -7,6 +7,7 @@ import {
   DisbursementSchedule,
   DisbursementScheduleStatus,
   DisbursementValueType,
+  OfferingIntensity,
   User,
 } from "@sims/sims-db";
 import {
@@ -34,7 +35,6 @@ import { LoggerService, InjectLogger } from "@sims/utilities/logger";
 import { SequenceControlService } from "../sequence-control/sequence-control.service";
 import { NotificationActionsService } from "../notifications";
 import {
-  DISBURSEMENT_DOCUMENT_NUMBER_SEQUENCE_GROUP,
   ENROLMENT_ALREADY_COMPLETED,
   ENROLMENT_CONFIRMATION_DATE_NOT_WITHIN_APPROVAL_PERIOD,
   ENROLMENT_INVALID_OPERATION_IN_THE_CURRENT_STATE,
@@ -229,6 +229,7 @@ export class ConfirmationOfEnrollmentService {
         "offering.actualTuitionCosts",
         "offering.programRelatedCosts",
         "offering.studyEndDate",
+        "offering.offeringIntensity",
         "disbursementValues.valueType",
         "disbursementValues.valueCode",
         "disbursementValues.valueAmount",
@@ -352,16 +353,18 @@ export class ConfirmationOfEnrollmentService {
    * @param applicationStatus application status of the disbursed application.
    * @param tuitionRemittanceRequestedAmount tuition remittance amount requested by the institution.
    * @param enrolmentConfirmationDate enrolment confirmation date.
+   * @param offeringIntensity offering intensity.
    */
   private async updateDisbursementAndApplicationCOEApproval(
     disbursementScheduleId: number,
     userId: number,
     applicationId: number,
     applicationStatus: ApplicationStatus,
     tuitionRemittanceRequestedAmount: number,
+    offeringIntensity: OfferingIntensity,
     enrolmentConfirmationDate?: Date,
   ): Promise<void> {
-    const documentNumber = await this.getNextDocumentNumber();
+    const documentNumber = await this.getNextDocumentNumber(offeringIntensity);
     const auditUser = { id: userId } as User;
     const coeConfirmationDate = enrolmentConfirmationDate ?? new Date();
 
@@ -649,6 +652,8 @@ export class ConfirmationOfEnrollmentService {
       disbursementSchedule.studentAssessment.application.id,
       disbursementSchedule.studentAssessment.application.applicationStatus,
       tuitionRemittanceAmount,
+      disbursementSchedule.studentAssessment.application.currentAssessment
+        .offering.offeringIntensity,
       options?.enrolmentConfirmationDate,
     );
   }
@@ -757,12 +762,16 @@ export class ConfirmationOfEnrollmentService {
   /**
    * Generates the next document number to be associated
    * with a disbursement.
+   * @param offeringIntensity offering intensity.
    * @returns sequence number for disbursement document number.
    */
-  private async getNextDocumentNumber(): Promise<number> {
+  private async getNextDocumentNumber(
+    offeringIntensity: OfferingIntensity,
+  ): Promise<number> {
+    const sequenceGroupName = `${offeringIntensity}_DISBURSEMENT_DOCUMENT_NUMBER`;
     let nextDocumentNumber: number;
     await this.sequenceService.consumeNextSequence(
-      DISBURSEMENT_DOCUMENT_NUMBER_SEQUENCE_GROUP,
+      sequenceGroupName,
       async (nextSequenceNumber) => {
         nextDocumentNumber = nextSequenceNumber;
       },

sources/packages/backend/libs/services/src/constants/disbursements.constants.ts

@@ -35,5 +35,3 @@ export const BC_TOTAL_GRANT_AWARD_CODE = "BCSG";
 export const BC_STUDENT_LOAN_AWARD_CODE = "BCSL";
 export const CANADA_STUDENT_LOAN_FULL_TIME_AWARD_CODE = "CSLF";
 export const CANADA_STUDENT_LOAN_PART_TIME_AWARD_CODE = "CSLP";
-export const DISBURSEMENT_DOCUMENT_NUMBER_SEQUENCE_GROUP =
-  "DISBURSEMENT_DOCUMENT_NUMBER";