Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4132 - Update Form IO (Fix Eligible Amount) #4194

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

lewischen-aot
Copy link
Collaborator

@lewischen-aot lewischen-aot commented Jan 2, 2025

  • Set "refreshOnChange": true to display eligible amount.

image

  • Removed "Submit application" button for pages before the last page.

image

@lewischen-aot lewischen-aot self-assigned this Jan 2, 2025
@lewischen-aot lewischen-aot changed the title 4132 #4132 - Update Form IO (Fix Eligible Amount) Jan 2, 2025
Copy link

sonarqubecloud bot commented Jan 2, 2025

@lewischen-aot lewischen-aot added Form.io Form IO definitions changed. Web portal labels Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.22% ( 3782 / 17020 )
Methods: 10.19% ( 219 / 2150 )
Lines: 25.66% ( 3277 / 12770 )
Branches: 13.62% ( 286 / 2100 )

Copy link

github-actions bot commented Jan 2, 2025

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

github-actions bot commented Jan 2, 2025

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.14% ( 1249 / 1450 )
Methods: 82.42% ( 136 / 165 )
Lines: 88.51% ( 1032 / 1166 )
Branches: 68.07% ( 81 / 119 )

Copy link

github-actions bot commented Jan 2, 2025

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

@lewischen-aot lewischen-aot marked this pull request as ready for review January 2, 2025 22:17
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an actual fix and should be considered a change in the actual behavior to prevent an error where the form may be submitted without triggering all the required validations.
@CarlyCotton add the below AC to track this and QAs will be advised about the change. If required a ticket will be created to investigate the validations issue.

The application submission button (top) should only be displayed on the final page.

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly taking care of these two questions. Looks good 👍

Copy link
Collaborator

@bidyashish bidyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @lewischen-aot

@lewischen-aot lewischen-aot added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit 23bc454 Jan 3, 2025
21 checks passed
@lewischen-aot lewischen-aot deleted the fix/#4132-formio-upgrade-eligible branch January 3, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Form.io Form IO definitions changed. Web portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants