Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3816 - Update to personal information and family information for 2025-2026 #4193

Merged

Conversation

dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Jan 2, 2025

Update to personal information and family information for 2025-2026

Updates

  • Reorder application questions

image

  • Update titles of question categories
    image

image

image

image

image

  • Move dependent information to personal information tab

image

  • Move residency information to personal information tab
    image

  • Show family information tab only if answer to dependent question is Yes.

image

image

@dheepak-aot dheepak-aot added the Form.io Form IO definitions changed. label Jan 2, 2025
@dheepak-aot dheepak-aot self-assigned this Jan 2, 2025
@lewischen-aot lewischen-aot self-requested a review January 2, 2025 22:29
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with the questions reorganizations, only one minor comment, please take a look.

Copy link
Collaborator

@lewischen-aot lewischen-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice work moving uploaders from one page to another.

Copy link

sonarqubecloud bot commented Jan 2, 2025

Copy link

github-actions bot commented Jan 2, 2025

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.22% ( 3782 / 17020 )
Methods: 10.19% ( 219 / 2150 )
Lines: 25.66% ( 3277 / 12770 )
Branches: 13.62% ( 286 / 2100 )

Copy link

github-actions bot commented Jan 2, 2025

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

github-actions bot commented Jan 2, 2025

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.14% ( 1249 / 1450 )
Methods: 82.42% ( 136 / 165 )
Lines: 88.51% ( 1032 / 1166 )
Branches: 68.07% ( 81 / 119 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, looks good 👍

Copy link

github-actions bot commented Jan 2, 2025

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

@dheepak-aot dheepak-aot added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit 1ab55a4 Jan 2, 2025
21 checks passed
@dheepak-aot dheepak-aot deleted the enhancement/#3816-personal-information-tab-shuffle branch January 3, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Form.io Form IO definitions changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants