Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4076 - Queue Monitoring - Schedulers Refactor (e-Cert and e-Cert Feedback) #4159

Merged
merged 1 commit into from
Dec 24, 2024
Merged

#4076 - Queue Monitoring - Schedulers Refactor (e-Cert and e-Cert Feedback) #4159

merged 1 commit into from
Dec 24, 2024

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Dec 19, 2024 •
edited
Loading

Refactored the below schedulers.

  • ecert-full-time-feedback
  • ecert-full-time-process
  • ecert-part-time-feedback
  • ecert-part-time-process

@andrewsignori-aot andrewsignori-aot self-assigned this Dec 19, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.15% ( 3783 / 17080 )
Methods: 10.12% ( 219 / 2165 )
Lines: 25.56% ( 3278 / 12825 )
Branches: 13.68% ( 286 / 2090 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

@andrewsignori-aot andrewsignori-aot changed the title #4079 - Queue Monitoring - Schedulers Refactor (e-Cert and e-Cert Feedback) #4076 - Queue Monitoring - Schedulers Refactor (e-Cert and e-Cert Feedback) Dec 20, 2024
@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 82.92% ( 1277 / 1540 )
Methods: 71.12% ( 133 / 187 )
Lines: 85.91% ( 1067 / 1242 )
Branches: 69.37% ( 77 / 111 )

@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review December 20, 2024 23:24
dheepak-aot
dheepak-aot reviewed Dec 21, 2024
View reviewed changes
...gration/ecert-integration/_tests_/ecert-full-time-feedback-integration.scheduler.e2e-spec.ts

// Assert
// Act/Assert
await expect(processor.processQueue(mockedJob.job)).rejects.toThrowError(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dheepak-aot
dheepak-aot approved these changes Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job and great progress with schedulers 👍

guru-aot
guru-aot approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @andrewsignori-aot

@andrewsignori-aot andrewsignori-aot added this pull request to the merge queue Dec 24, 2024
Merged via the queue into main with commit 9ca9cd2 Dec 24, 2024
21 checks passed
@andrewsignori-aot andrewsignori-aot deleted the feature/#4076-schedulers-refactor-part-5 branch December 24, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

Assignees

@andrewsignori-aot andrewsignori-aot

Labels
Queue Consumers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewsignori-aot @dheepak-aot @guru-aot