Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4076 - Queue Monitoring - Schedulers Refactor (SIN validation and loan balance) #4118

Merged
merged 7 commits into from
Dec 18, 2024

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Dec 16, 2024

  • Refactored SIN validation-related schedulers and student loan balance import.
  • Adjusted E2E tests.

@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review December 17, 2024 16:35
Copy link
Collaborator

@bidyashish bidyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Nice refactor!

const results = await this.sinValidationProcessingService.processResponses(
auditUser.id,
);
await summary.info("ESDC SIN validation response files processed.");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a processSummary.info with similar context ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we talked, removing the friendly messages from the processor since the BaseQueue has some similar to indicate the start and end of the processing.

@dheepak-aot
Copy link
Collaborator

Good job @andrewsignori-aot. Added a few minor comments.

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.05% ( 3785 / 17168 )
Methods: 10.05% ( 219 / 2180 )
Lines: 25.43% ( 3280 / 12898 )
Branches: 13.68% ( 286 / 2090 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 81.15% ( 1309 / 1613 )
Methods: 66.34% ( 134 / 202 )
Lines: 84.38% ( 1097 / 1300 )
Branches: 70.27% ( 78 / 111 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. Looks good 👍

@andrewsignori-aot andrewsignori-aot added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit c8a8695 Dec 18, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants