#4076 - Queue Monitoring - Schedulers Refactor (SIN validation and loan balance) #4118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andrewsignori-aot
commented
Dec 16, 2024
•
andrewsignori-aot
commented
- Refactored SIN validation-related schedulers and student loan balance import.
- Adjusted E2E tests.
bidyashish
approved these changes
Dec 17, 2024
dheepak-aot
reviewed
Dec 18, 2024
...egration/sin-validation-integration/sin-validation-process-response-integration.scheduler.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 18, 2024
...c-integration/student-loan-balances/student-loan-balances-part-time-integration.scheduler.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 18, 2024
| const results = await this.sinValidationProcessingService.processResponses( | ||
| auditUser.id, | ||
| ); | ||
| await summary.info("ESDC SIN validation response files processed."); |
There was a problem hiding this comment.
Can we have a processSummary.info with similar context ?
There was a problem hiding this comment.
As we talked, removing the friendly messages from the processor since the BaseQueue has some similar to indicate the start and end of the processing.
dheepak-aot
reviewed
Dec 18, 2024
...c-integration/student-loan-balances/student-loan-balances-part-time-integration.scheduler.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 18, 2024
...c-integration/student-loan-balances/student-loan-balances-part-time-integration.scheduler.ts
Outdated
Show resolved
Hide resolved
|
Good job @andrewsignori-aot. Added a few minor comments. |
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
approved these changes
Dec 18, 2024
andrewsignori-aot
temporarily deployed
to
DEV
GitHub Actions
Inactive
andrewsignori-aot
temporarily deployed
to
DEV
GitHub Actions
Inactive
andrewsignori-aot
temporarily deployed
to
DEV
GitHub Actions
Inactive
andrewsignori-aot
temporarily deployed
to
DEV
GitHub Actions
Inactive
andrewsignori-aot
temporarily deployed
to
DEV
GitHub Actions
Inactive
andrewsignori-aot
temporarily deployed
to
DEV
GitHub Actions
Inactive
andrewsignori-aot
temporarily deployed
to
DEV
GitHub Actions
Inactive
andrewsignori-aot
deleted the
feature/#4076-schedulers-refactor-part-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.