#4076 - Queue Monitoring - Schedulers Refactor (SFAS Integration) #4097
Conversation
andrewsignori-aot
changed the title
...rocessors/schedulers/sfas-integration/_tests_/sims-to-sfas-integration.scheduler.e2e-spec.ts
Show resolved
Hide resolved
| * @param job job. | ||
| * @returns process summary. | ||
| * @param _job process job. | ||
| * @param processSummary process summary for logging. | ||
| */ | ||
| @Process() |
There was a problem hiding this comment.
The decorator is expected to be removed right?
| // Execute the import of all files records. | ||
| await processInParallel( | ||
| (record) => | ||
| this.importRecord(record, downloadResult.header.creationDate, result), | ||
| (record) => this.importRecord(record, downloadResult.header.creationDate), |
There was a problem hiding this comment.
Can we pass the processSummary to the importRecord method? So that the errors logged inside that method will have both job and console logs.
There was a problem hiding this comment.
By doing further review I understood that when error is thrown the parent method will take care of the cross-cutting concerns so you can ignore the comment.
There was a problem hiding this comment.
I did not believe it was necessary since the first error should interrupt the import and it will logged either way.
| const mockedJob = mockBullJob<void>(); | ||
|
|
||
| // Act/Assert | ||
| await expect(processor.processQueue(mockedJob.job)).rejects.toThrow( |
|
Good job @andrewsignori-aot. Just one comment on the decorator. |
There was a problem hiding this comment.
Great start. Looks good. Please remove the un-used import here sims-to-sfas-integration.scheduler.ts
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
deleted the
feature/#4076-schedulers-refactor-part-1
branch
SFASProcessingResultwith theprocessSummary. This refactor is not expected to be done for every scheduler.