#3941 - Update FT Assessment & Configure Disbursement #4096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepestana-aot
added
E2E/Unit tests
Camunda Worflow
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
bidyashish
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Please have a look at comments.
All the .bpmn files contains lots of changes making it difficult to trace the only needed changes in the files.
Recommendations:
- Clean up BPMN files to only show essential changes
- Document the business requirements driving the BCAG eligibility changes
- Consider adding unit tests for the new 2025-2026 values
- Review and clean up formatting changes that don't affect functionality
sources/packages/backend/workflow/src/workflow-definitions/fulltime-assessment-2022-2023.bpmn
Show resolved
Hide resolved
sources/packages/backend/workflow/src/workflow-definitions/fulltime-assessment-2022-2023.bpmn
Show resolved
Hide resolved
sources/packages/backend/workflow/src/workflow-definitions/fulltime-assessment-decisions.dmn
Show resolved
Hide resolved
...3-2024/fulltime-assessment/eligibility/fulltime-assessment-eligibility-BCAG2Year.e2e-spec.ts
Show resolved
Hide resolved
andrewsignori-aot
approved these changes
Dec 18, 2024
andrepestana-aot
deleted the
3941_update_ft_assessment_configure_disbursement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing values for 2025-2026 to dmn;
Some vars were renamed to fix an issue with the original workflow provided with the ticket:
BCAG eligibility was changed and confirmed with Biz (removed graduate certificate and diploma from condition). Tests were changed accordingly:
Fixed some E2E test values changed after applying the new workflow;
NOA:
