Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3645 - Content: Support Portal: Welcome Page- Formio issue #4057

Merged
merged 1 commit into from
Dec 10, 2024
Merged

#3645 - Content: Support Portal: Welcome Page- Formio issue #4057

merged 1 commit into from
Dec 10, 2024

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Dec 10, 2024 •
edited
Loading

Deploy problem:
image

  • Made button key unique.

@andrepestana-aot andrepestana-aot self-assigned this Dec 10, 2024
@andrepestana-aot andrepestana-aot added Form.io Form IO definitions changed. Supporting User labels Dec 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@andrepestana-aot andrepestana-aot marked this pull request as ready for review December 10, 2024 00:46
@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.97% ( 3753 / 17085 )
Methods: 10.09% ( 215 / 2130 )
Lines: 25.31% ( 3258 / 12870 )
Branches: 13.43% ( 280 / 2085 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 84.43% ( 1334 / 1580 )
Methods: 82.1% ( 133 / 162 )
Lines: 85.99% ( 1123 / 1306 )
Branches: 69.64% ( 78 / 112 )

bidyashish
bidyashish approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@bidyashish bidyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.16% ( 5869 / 8739 )
Methods: 64.75% ( 722 / 1115 )
Lines: 71.15% ( 4612 / 6482 )
Branches: 46.85% ( 535 / 1142 )

andrewsignori-aot
andrewsignori-aot approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@andrepestana-aot andrepestana-aot added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 1ed1e86 Dec 10, 2024
21 checks passed
@andrepestana-aot andrepestana-aot deleted the 3645_content_support_portal_welcome_page_form_issue branch December 13, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidyashish bidyashish bidyashish approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

Assignees

@andrepestana-aot andrepestana-aot

Labels
Form.io Form IO definitions changed. Supporting User
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrepestana-aot @bidyashish @andrewsignori-aot