-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3645 - Content: Support Portal: Welcome Page #4054
#3645 - Content: Support Portal: Welcome Page #4054
Conversation
"label": "isFulltimeAllowed", | ||
"protected": false, | ||
"unique": false, | ||
"persistent": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there is a need, hidden should be set as "persistent": false
.
@@ -699,7 +998,7 @@ | |||
"disabled": false, | |||
"tableView": false, | |||
"modalEdit": false, | |||
"key": "startPartnerInformationRequestButton", | |||
"key": "startPartnerInformationRequestButtonFulltimeNotAllowed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this change required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, minor comments only. Please take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than the key rename i am good to approve.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Fulltime allowed: