Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3645 - Content: Support Portal: Welcome Page #4054

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Dec 9, 2024

  • Content changes;
  • Removed "parents" panel when fulltime is not allowed.

image

Fulltime allowed:
image

@andrepestana-aot andrepestana-aot self-assigned this Dec 9, 2024
@andrepestana-aot andrepestana-aot added Form.io Form IO definitions changed. Supporting User labels Dec 9, 2024
@andrepestana-aot andrepestana-aot marked this pull request as ready for review December 9, 2024 21:44
"label": "isFulltimeAllowed",
"protected": false,
"unique": false,
"persistent": true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there is a need, hidden should be set as "persistent": false.

@@ -699,7 +998,7 @@
"disabled": false,
"tableView": false,
"modalEdit": false,
"key": "startPartnerInformationRequestButton",
"key": "startPartnerInformationRequestButtonFulltimeNotAllowed",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change required?

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, minor comments only. Please take a look.

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than the key rename i am good to approve.

Copy link

sonarqubecloud bot commented Dec 9, 2024

Copy link

github-actions bot commented Dec 9, 2024

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.97% ( 3753 / 17085 )
Methods: 10.09% ( 215 / 2130 )
Lines: 25.31% ( 3258 / 12870 )
Branches: 13.43% ( 280 / 2085 )

Copy link

github-actions bot commented Dec 9, 2024

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

github-actions bot commented Dec 9, 2024

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 84.43% ( 1334 / 1580 )
Methods: 82.1% ( 133 / 162 )
Lines: 85.99% ( 1123 / 1306 )
Branches: 69.64% ( 78 / 112 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link

github-actions bot commented Dec 9, 2024

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.16% ( 5869 / 8739 )
Methods: 64.75% ( 722 / 1115 )
Lines: 71.15% ( 4612 / 6482 )
Branches: 46.85% ( 535 / 1142 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Form.io Form IO definitions changed. Supporting User
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants