Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3981 - Model SDPR API - Query fix #4038

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Dec 6, 2024

  • Querying the id is necessary for TypeOrm to bring multiple numbers for the applications array. Otherwise, it brings only one application in the array in the student object.

image

@andrepestana-aot andrepestana-aot self-assigned this Dec 6, 2024
Copy link

sonarqubecloud bot commented Dec 6, 2024

Copy link

github-actions bot commented Dec 6, 2024

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.97% ( 3753 / 17085 )
Methods: 10.09% ( 215 / 2130 )
Lines: 25.31% ( 3258 / 12870 )
Branches: 13.43% ( 280 / 2085 )

Copy link

github-actions bot commented Dec 6, 2024

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

@andrepestana-aot andrepestana-aot added Bug Something isn't working SIMS-Api SIMS-Api labels Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 84.43% ( 1334 / 1580 )
Methods: 82.1% ( 133 / 162 )
Lines: 85.99% ( 1123 / 1306 )
Branches: 69.64% ( 78 / 112 )

@andrepestana-aot andrepestana-aot marked this pull request as ready for review December 6, 2024 01:24
Copy link

github-actions bot commented Dec 6, 2024

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.16% ( 5869 / 8739 )
Methods: 64.75% ( 722 / 1115 )
Lines: 71.15% ( 4612 / 6482 )
Branches: 46.85% ( 535 / 1142 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Approving as it is very minor and not keep the PR waiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working SIMS-Api SIMS-Api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants