Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3666 - Queue Monitoring - Adjusted Queues Cleanup Period #4021

Merged

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Dec 3, 2024

As per the conversation on the Teams chat, adjusted the queues to use the out-of-box cleanup configuration.

Copy link

sonarqubecloud bot commented Dec 3, 2024

Copy link

github-actions bot commented Dec 3, 2024

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.03% ( 3742 / 16986 )
Methods: 10.08% ( 214 / 2122 )
Lines: 25.39% ( 3250 / 12802 )
Branches: 13.48% ( 278 / 2062 )

Copy link

github-actions bot commented Dec 3, 2024

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

github-actions bot commented Dec 3, 2024

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 83.98% ( 1269 / 1511 )
Methods: 81.53% ( 128 / 157 )
Lines: 85.57% ( 1073 / 1254 )
Branches: 68% ( 68 / 100 )

Copy link

github-actions bot commented Dec 3, 2024

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.17% ( 5844 / 8700 )
Methods: 64.86% ( 720 / 1110 )
Lines: 71.14% ( 4592 / 6455 )
Branches: 46.87% ( 532 / 1135 )

@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review December 3, 2024 23:29
@dheepak-aot dheepak-aot self-requested a review December 3, 2024 23:42
Comment on lines +81 to +85
if (queueConfig.queueConfiguration.cleanUpPeriod) {
config.removeOnComplete = {
age: queueConfig.queueConfiguration.cleanUpPeriod / 1000,
};
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants