#3453 - COE for $0/Not Eligible Assessments - Part 1

[lewischen-aot]

The first part of the PR resolves the following business AC:

• Do not show $0/Ineligible disbursements to Institution users, even if COE is "Required"

The PR includes the changes for two modules: API endpoint and workers.

• Created a new flag has_estimated_awards in the disbursement table to indicate the $0 disbursement during the saving assessments in the workers.
• Added method updateDisbursementsHasEstimatedAwards to update has_estimated_awards for each disbursement in the method saveAssessmentData.
• Added new E2E test case for the institution API endpoint getCOESummary
  • "Should get the count of COE current summary as zero when there is 1 COE that doesn't have estimated awards."

Rollback Evidence

SQL query to run on Production as required from comment

UPDATE
    sims.disbursement_schedules
SET
    has_estimated_awards = CASE
        WHEN disbursement_total_amounts.value_amount > 0 THEN true
        ELSE false
    END
FROM
    (
        SELECT
            disbursement_value.disbursement_schedule_id AS disbursement_schedule_id,
            sum(disbursement_value.value_amount) AS value_amount
        FROM
            sims.disbursement_values disbursement_value
        GROUP BY
            disbursement_value.disbursement_schedule_id
    ) disbursement_total_amounts
WHERE
    sims.disbursement_schedules.id = disbursement_total_amounts.disbursement_schedule_id;

The next part will cover the changes for another two modules: COE Request report and e-Cert queue consumer.

[sh16011993]

Everything looks good. Just one question regarding the changes in the e2e test file.

[dheepak-aot]

Nice start @lewischen-aot . Please have a look into the comments.

One question. Is ECE integration going to part of next PR?

[dheepak-aot]

As a suggestion, I would recommend the following UPDATE SQL considering less complex to read and understand IMO.

But it is not a blocker. Existing update still does the work.

update
	sims.disbursement_schedules
set
	has_estimated_awards = (case
		when exists (
	select
			1
	from
			sims.disbursement_values disbursement_value
	where
			disbursement_value.disbursement_schedule_id = sims.disbursement_schedules.id
		and disbursement_value.value_amount > 0) then true
	else false
end);

[lewischen-aot]

Thanks for the query. I updated this query in this commit, but sonarcloud quality gate failed.



I am reverting it back with the update in this comment.

[dheepak-aot]

Asking for my understanding. Was this required?

[lewischen-aot]

Shashank asked the same question, and I replied in his comment: here.

[dheepak-aot]

Thanks for making the changes and writing extensive E2E tests. Added more comments. Please have a look.

[dheepak-aot]

Minor. Add the //Act comment before line 394.

[dheepak-aot]

The act comment must be right before line 471.

[dheepak-aot]

Thanks for making the changes and also taking effort to split the PRs.
Approved with 2 minor comments.

Please feel free to merge once the 2 minor comments are addressed.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Backend Unit Tests Coverage Report

Totals
Statements:	21.99% ( 3742 / 17018 )
Methods:	10.08% ( 214 / 2124 )
Lines:	25.33% ( 3250 / 12833 )
Branches:	13.49% ( 278 / 2061 )

[github-actions]

E2E Workflow Workers Coverage Report

Totals
Statements:	65.43% ( 583 / 891 )
Methods:	59.26% ( 64 / 108 )
Lines:	68.54% ( 464 / 677 )
Branches:	51.89% ( 55 / 106 )

[github-actions]

E2E Queue Consumers Coverage Report

Totals
Statements:	83.73% ( 1292 / 1543 )
Methods:	81.65% ( 129 / 158 )
Lines:	85.21% ( 1095 / 1285 )
Branches:	68% ( 68 / 100 )

[github-actions]

E2E SIMS API Coverage Report

Totals
Statements:	67.17% ( 5844 / 8700 )
Methods:	64.86% ( 720 / 1110 )
Lines:	71.14% ( 4592 / 6455 )
Branches:	46.87% ( 532 / 1135 )

[sh16011993]

Great work @lewischen-aot 👍