Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3763 - Ministry Reports - Disbursements Without Supplier (CAS) - Query fix #4004

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Nov 27, 2024

Fixed joins to sin_validations and cas_suppliers:

From:

      INNER JOIN sims.sin_validations sin_validations ON students.id = sin_validations.student_id
      INNER JOIN sims.cas_suppliers cas_suppliers ON cas_suppliers.student_id = students.id

To:

      INNER JOIN sims.sin_validations sin_validations ON students.sin_validation_id = sin_validations.id
      INNER JOIN sims.cas_suppliers cas_suppliers ON students.cas_supplier_id = cas_suppliers.id

-Migration revert:
image

@andrepestana-aot andrepestana-aot self-assigned this Nov 27, 2024
@andrepestana-aot andrepestana-aot added Bug Something isn't working DB DB migration involved labels Nov 27, 2024
@andrepestana-aot andrepestana-aot marked this pull request as ready for review November 27, 2024 02:29
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.07% ( 3733 / 16913 )
Methods: 10.16% ( 214 / 2107 )
Lines: 25.42% ( 3241 / 12751 )
Branches: 13.53% ( 278 / 2055 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 84.39% ( 1238 / 1467 )
Methods: 84.51% ( 120 / 142 )
Lines: 85.61% ( 1053 / 1230 )
Branches: 68.42% ( 65 / 95 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.04% ( 5810 / 8667 )
Methods: 64.86% ( 720 / 1110 )
Lines: 70.99% ( 4561 / 6425 )
Branches: 46.73% ( 529 / 1132 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @andrepestana-aot

@andrepestana-aot andrepestana-aot added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 99df144 Nov 27, 2024
20 checks passed
@andrepestana-aot andrepestana-aot deleted the 3763_ministry_reports_disbursements_without_valid_supplier_query_fix branch November 27, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working DB DB migration involved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants