#3768 - CAS Supplier Maintenance Updates Part 1 #4002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh16011993
approved these changes
Nov 27, 2024
sh16011993
reviewed
Nov 27, 2024
| manualVerifiedSupplier.creator = auditUser; | ||
|
|
||
| // Set manual verified CAS Supplier for the student. | ||
| student.casSupplier = manualVerifiedSupplier; |
There was a problem hiding this comment.
Thanks for the fix ❤️
| ADD | ||
| COLUMN student_profile_snapshot jsonb; | ||
|
|
||
| COMMENT ON COLUMN sims.cas_suppliers.student_profile_snapshot IS 'Snapshot of the student profile details which is captured when the CAS supplier is set to be active.'; |
There was a problem hiding this comment.
I believe it would be "to be valid", right?
| @@ -148,3 +159,16 @@ export interface SupplierAddress { | |||
| siteProtected?: string; | |||
| lastUpdated: Date; | |||
| } | |||
| /** | |||
There was a problem hiding this comment.
Minor, please add a blank line.
| * Student profile snapshot information. | ||
| */ | ||
| interface StudentProfileSnapshot { | ||
| givenName: string; |
There was a problem hiding this comment.
Since this is the snapshot of the student profile I would recommend that it uses the "SIMS tables" conventions where givenName would be firstName. Not a blocker though.
andrewsignori-aot
approved these changes
Nov 27, 2024
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
deleted the
feature/#3768-cas-supplier-maintenance-updates-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added New Column
student_profile_snapshottosims.cas_suppliersBug Fix
sims.studentswhile adding manually the CAS SUPPLIER NUMBER and SITE CODE by ministry user.Rollback Evidence