#3693 - [Bug] 0 is removed from the Exceptional costs field #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh16011993
added
Web portal
Institution
sh16011993
changed the title
sh16011993
changed the title
sh16011993
changed the title
sources/packages/backend/libs/sims-db/src/transformers/numeric.transformer.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Nov 26, 2024
| @@ -14,7 +14,7 @@ export const numericTransformer: ValueTransformer = { | |||
| * @returns numeric/decimal string converted to a number. | |||
| */ | |||
| from: (value: string | null): number | null => { | |||
| if (value) { | |||
| if (value !== null && value !== undefined) { | |||
There was a problem hiding this comment.
Suggestion from my side to use the following solution as it checks for a string which can be a number or not.
from: (value: string | null): number | null => {
if (Number.isFinite(parseFloat(value))) {
return parseFloat(value);
}
return null;
}There was a problem hiding this comment.
Thanks for suggesting it @dheepak-aot and thanks for implementing it @sh16011993.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
guru-aot
approved these changes
Nov 26, 2024
sh16011993
deleted the
3693_bug_institution_0_removed_exceptional_costs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of this PR, the following bug was fixed:
Bug: 0 is removed from the Exceptional costs field and the warning banner as shown below shows up. Likewise, for the other 3 cost fields.
Fix:
numericTransformeron receiving the value of 0 from the database was returning it asnullrather than the numeric value0. Updated the code to fix it and return0instead ofnull.2024-11-26.13-05-35.mp4