Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3763 - Ministry Reports - Disbursements Without Supplier (CAS) #3998

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Nov 26, 2024

  • Created report Disbursements Without Valid Supplier:
    image

  • Created E2E test.

Migration revert:
image

@andrepestana-aot andrepestana-aot self-assigned this Nov 26, 2024
@andrepestana-aot andrepestana-aot added the Ministry Ministry Features label Nov 26, 2024
@andrepestana-aot andrepestana-aot marked this pull request as ready for review November 26, 2024 01:04
@lewischen-aot lewischen-aot self-requested a review November 26, 2024 17:05
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, please take a look at the comments.

Copy link

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, look good 👍

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.07% ( 3733 / 16912 )
Methods: 10.16% ( 214 / 2107 )
Lines: 25.42% ( 3241 / 12750 )
Branches: 13.53% ( 278 / 2055 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link
Collaborator

@lewischen-aot lewischen-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for making the changes and adopting the proposed query.

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 84.39% ( 1238 / 1467 )
Methods: 84.51% ( 120 / 142 )
Lines: 85.61% ( 1053 / 1230 )
Branches: 68.42% ( 65 / 95 )

@andrepestana-aot andrepestana-aot added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit c2e0a5f Nov 26, 2024
19 checks passed
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.04% ( 5810 / 8667 )
Methods: 64.86% ( 720 / 1110 )
Lines: 70.99% ( 4561 / 6425 )
Branches: 46.73% ( 529 / 1132 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ministry Ministry Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants