-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3763 - Ministry Reports - Disbursements Without Supplier (CAS) #3998
#3763 - Ministry Reports - Disbursements Without Supplier (CAS) #3998
Conversation
...nd/apps/db-migrations/src/sql/Reports/Create-disbursements-without-valid-supplier-report.sql
Show resolved
Hide resolved
sources/packages/backend/libs/test-utils/src/factories/cas-supplier.ts
Outdated
Show resolved
Hide resolved
...nd/apps/db-migrations/src/sql/Reports/Create-disbursements-without-valid-supplier-report.sql
Outdated
Show resolved
Hide resolved
...nd/apps/db-migrations/src/sql/Reports/Create-disbursements-without-valid-supplier-report.sql
Show resolved
Hide resolved
...nd/apps/db-migrations/src/sql/Reports/Create-disbursements-without-valid-supplier-report.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, please take a look at the comments.
...nd/apps/db-migrations/src/sql/Reports/Create-disbursements-without-valid-supplier-report.sql
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes, look good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for making the changes and adopting the proposed query.
Created report Disbursements Without Valid Supplier:
![image](https://private-user-images.githubusercontent.com/78114138/389749738-9c7ee806-3deb-468c-b240-cf5b9e3ede28.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MjkyMTQsIm5iZiI6MTczODkyODkxNCwicGF0aCI6Ii83ODExNDEzOC8zODk3NDk3MzgtOWM3ZWU4MDYtM2RlYi00NjhjLWIyNDAtY2Y1YjllM2VkZTI4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDExNDgzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFkNmI0MTA4MWM5YjI2OTc1NDJiODIzYjY1ZjVjMGQ2YWU2NmUzMDM2Mjk1ZTkxMzdlNWU1MzI3MTlkMDljOGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.TkF1_w5vMHVONms9RNoWL62iEx-zsiy0KbOOsUl2tKo)
Created E2E test.
Migration revert:
![image](https://private-user-images.githubusercontent.com/78114138/389749225-4cf40a92-eddd-4410-bdac-92574234add0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MjkyMTQsIm5iZiI6MTczODkyODkxNCwicGF0aCI6Ii83ODExNDEzOC8zODk3NDkyMjUtNGNmNDBhOTItZWRkZC00NDEwLWJkYWMtOTI1NzQyMzRhZGQwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDExNDgzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYwMjdjMzExNGEwYzAwNDMzYmE4ZWE1NzAxN2RhMTE3MzkyOThiMGVjNzU5Njk2MmMyNDgzNWYxMzQ4M2IzMzYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.pIkEHLcp9XaAyEaxv_J2T8eQ2i9iA-9_t2Yp8SMhQhM)