Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3280 - Content: Ministry: Your Profile Info: Update content for “Deny request for a student account” modal #3990

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

bidyashish
Copy link
Collaborator

User story
As a ministry user, I want to deny the request for a student account so that they have to start over with the Basic BCeID account application.

Acceptance Criteria

  • Update current text “Denying the request means that the student will not be able to access the system using a Basic BCeID” to "Attention: Denied account requests are final and cannot be reactivated. Students will need to start over with the Basic BCeID account application process."

Supporting steps and screenshot
A student has created a new profile and it is sitting in the Student Requests>Accounts page
Click "View"
Click "Deny request"
Message displayed needs to be updated

Sample Demo
image

@bidyashish bidyashish self-assigned this Nov 22, 2024
@bidyashish bidyashish added Student Student Features Ministry Ministry Features labels Nov 22, 2024
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.03% ( 3718 / 16875 )
Methods: 10.17% ( 214 / 2105 )
Lines: 25.36% ( 3226 / 12719 )
Branches: 13.55% ( 278 / 2051 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 84.17% ( 1234 / 1466 )
Methods: 83.8% ( 119 / 142 )
Lines: 85.44% ( 1050 / 1229 )
Branches: 68.42% ( 65 / 95 )

@guru-aot guru-aot self-requested a review November 22, 2024 21:54
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @bidyashish

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.94% ( 5774 / 8625 )
Methods: 64.8% ( 718 / 1108 )
Lines: 70.87% ( 4531 / 6393 )
Branches: 46.71% ( 525 / 1124 )

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@bidyashish bidyashish added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 19c0ec8 Nov 22, 2024
20 checks passed
@bidyashish bidyashish deleted the feature/#3280-content-ministry-profile-info branch November 22, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ministry Ministry Features Student Student Features Web portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants