#3943 - Bug - restriction view when access limited #3982
Conversation
lewischen-aot
added
Bug
| @@ -160,6 +153,8 @@ export default defineComponent({ | |||
| return "Resolution reason is required."; | |||
| }; | |||
|
|
|||
| console.info("props.canResolveRestriction: ", props.canResolveRestriction); | |||
There was a problem hiding this comment.
Please remove the console.info.
| /> | ||
| </template> | ||
| </check-permission-role> | ||
| <footer-buttons |
There was a problem hiding this comment.
Check permission role is required and must not be removed.
| </check-permission-role> | ||
| <footer-buttons | ||
| :processing="processing" | ||
| :primaryLabel="allowUserToEdit ? 'Resolve restriction' : 'Close'" |
There was a problem hiding this comment.
I would suggest the following quick solution which would keep the primary behavior as primary and secondary behaviour as secondary not having to juggle based on the situation.
Solution
<template #footer>
<check-permission-role :role="allowedRole">
<template #="{ notAllowed }">
<footer-buttons
primaryLabel="Resolve restriction"
:secondaryLabel="allowUserToEdit ? 'Cancel' : 'Close'"
@primaryClick="submit"
@secondaryClick="cancel"
:disablePrimaryButton="notAllowed"
:showPrimaryButton="allowUserToEdit"
/>
</template>
</check-permission-role>
</template>Note: there is no processing variable so removed :processing="processing"
Result:
View Active Restriction with permission
View resolved restriction with permission
View Resolved restriction without permission
There was a problem hiding this comment.
The solution looks great, and we can probably adopt this in other stories. Thanks @dheepak-aot
| secondaryLabel="Cancel" | ||
| @primaryClick="allowUserToEdit ? submit() : cancel()" | ||
| @secondaryClick="cancel" | ||
| :showSecondaryButton="allowUserToEdit" |
There was a problem hiding this comment.
Or as a bare minimal solution. This will disable primary button only if the edit action is possible.
There was a problem hiding this comment.
I agree with this solution, which is adopted in the latest commit.
|
Please have a look at the comments. |
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Screenshot
