#3710 - Stop part time BC funding - Implement new restriction effect

[bidyashish]

Technical

• Implement the same process already in place for full-time in apply-stop-bc-funding-restriction-full-time-step.ts.
• Try to share the same step if possible.
• Add E2E test to check the part-time step.

[andrewsignori-aot]

No need to be specific with the restriction if we find it as below (code from the same file).
No a blocker but it would prevent dealing with the restriction code directly since the E2E test is about the StopPartTimeBCFunding and not about a specific restriction.

const restriction = await db.restriction.findOne({
  where: {
    actionType: ArrayContains([
      RestrictionActionType.StopPartTimeBCFunding,
    ]),
  },
});

[guru-aot]

Not a blocker, but the above code is used in the test case

SIMS/sources/packages/backend/apps/queue-consumers/src/processors/schedulers/esdc-integration/ecert-integration/_tests_/ecert-part-time-process-integration.scheduler.e2e-spec.ts

Line 1057 in 3eec04e

it(

and can be used at beforeAll part of the test case and passed in both the implementations.

[bidyashish]

Thank you suggestion,
Updated the E2E to get restriction instead of B6A.

[andrewsignori-aot]

Thanks for making the change.
@guru-aot I am approving the PR since this entire comment was just a suggestion even though I saw value in your suggested change.

[andrewsignori-aot]

Nice work, please take a look at the comments.

[guru-aot]

Nice Work @bidyashish , please have a look on the comments.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Backend Unit Tests Coverage Report

Totals
Statements:	22.09% ( 3718 / 16831 )
Methods:	10.19% ( 214 / 2101 )
Lines:	25.43% ( 3226 / 12687 )
Branches:	13.61% ( 278 / 2043 )

[github-actions]

E2E Workflow Workers Coverage Report

Totals
Statements:	65.43% ( 583 / 891 )
Methods:	59.26% ( 64 / 108 )
Lines:	68.54% ( 464 / 677 )
Branches:	51.89% ( 55 / 106 )

[github-actions]

E2E Queue Consumers Coverage Report

Totals
Statements:	86.93% ( 1244 / 1431 )
Methods:	88.57% ( 124 / 140 )
Lines:	87.78% ( 1056 / 1203 )
Branches:	72.73% ( 64 / 88 )

[andrewsignori-aot]

Thanks for making the changes, looks good 👍

[github-actions]

E2E SIMS API Coverage Report

Totals
Statements:	66.96% ( 5773 / 8622 )
Methods:	64.8% ( 718 / 1108 )
Lines:	70.88% ( 4530 / 6391 )
Branches:	46.75% ( 525 / 1123 )

[guru-aot]

LGTM nice work @bidyashish