Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3788 - Gateway Assessment Data Update - PT & FT #3874

Merged

Conversation

andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Nov 1, 2024

  • Updated values for part-time and full-time.
  • No E2E adjustments were needed.

Part-time

Please see below the offering book and supplies (a.k.a. program-related costs) adjusted to the assessment's value.

image

image

Sample Assessment-related Data

{
  "weeks": 31,
  "tuitionCost": 5500,
  "childcareCost": 5376.08,
  "mandatoryFees": 350,
  "finalAwardTotal": 13767.08,
  "totalFamilyIncome": 24000,
  "transportationCost": 403,
  "totalAssessmentNeed": 13767.08,
  "booksAndSuppliesCost": 1798,
  "totalAcademicExpenses": 8391,
  "miscellaneousAllowance": 340,
  "exceptionalEducationCost": 600,
  "finalFederalAwardNetCSGDAmount": 1736,
  "finalFederalAwardNetCSGPAmount": 0,
  "finalFederalAwardNetCSLPAmount": 9511.08,
  "finalFederalAwardNetCSPTAmount": 2520,
  "finalProvincialAwardNetBCAGAmount": 0,
  "finalProvincialAwardNetSBSDAmount": 0
}

Full-time

Please see below some values from the full-time NOA generated. The NOA changes for full-time are not critical at the moment and the NOA must be adjusted. For instance, federal and provincial awards are just duplicated right now and they display the same values.

image

@andrewsignori-aot andrewsignori-aot added Student Student Features Camunda Worflow Involves camunda workflow changes labels Nov 1, 2024
@andrewsignori-aot andrewsignori-aot self-assigned this Nov 1, 2024
Copy link

sonarqubecloud bot commented Nov 1, 2024

Copy link

github-actions bot commented Nov 1, 2024

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.3% ( 3695 / 16568 )
Methods: 10.31% ( 212 / 2057 )
Lines: 25.63% ( 3205 / 12507 )
Branches: 13.87% ( 278 / 2004 )

Copy link

github-actions bot commented Nov 1, 2024

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

github-actions bot commented Nov 1, 2024

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 85.88% ( 1216 / 1416 )
Methods: 87.86% ( 123 / 140 )
Lines: 86.8% ( 1032 / 1189 )
Branches: 70.11% ( 61 / 87 )

Copy link

github-actions bot commented Nov 1, 2024

E2E SIMS API Coverage Report

Totals Coverage
Statements: 65.65% ( 5574 / 8490 )
Methods: 63.07% ( 683 / 1083 )
Lines: 69.83% ( 4404 / 6307 )
Branches: 44.27% ( 487 / 1100 )

@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review November 1, 2024 20:44
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<bpmn:definitions xmlns:bpmn="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:zeebe="http://camunda.org/schema/zeebe/1.0" xmlns:di="http://www.omg.org/spec/DD/20100524/DI" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:modeler="http://camunda.org/schema/modeler/1.0" xmlns:camunda="http://camunda.org/schema/1.0/bpmn" id="Definitions_1" targetNamespace="http://bpmn.io/schema/bpmn" exporter="Camunda Modeler" exporterVersion="5.23.0" modeler:executionPlatform="Camunda Cloud" modeler:executionPlatformVersion="8.1.0" camunda:diagramRelationId="f874f098-96b6-491d-81ec-ecf7a0d8c67a">
<bpmn:definitions xmlns:bpmn="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:zeebe="http://camunda.org/schema/zeebe/1.0" xmlns:di="http://www.omg.org/spec/DD/20100524/DI" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:modeler="http://camunda.org/schema/modeler/1.0" xmlns:camunda="http://camunda.org/schema/1.0/bpmn" id="Definitions_1" targetNamespace="http://bpmn.io/schema/bpmn" exporter="Camunda Modeler" exporterVersion="5.28.0" modeler:executionPlatform="Camunda Cloud" modeler:executionPlatformVersion="8.6.0" camunda:diagramRelationId="f874f098-96b6-491d-81ec-ecf7a0d8c67a">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -306,7 +306,7 @@
<bpmn:serviceTask id="save-assessment-data-part-time-task" name="Save assessment output">
<bpmn:extensionElements>
<zeebe:ioMapping>
<zeebe:input source="={&#10; weeks: offeringWeeks,&#10; tuitionCost: offeringActualTuitionCosts,&#10; booksAndSuppliesCost: offeringProgramRelatedCosts,&#10; mandatoryFees: calculatedDataMandatoryFees,&#10; exceptionalEducationCost: offeringExceptionalExpenses,&#10; childcareCost: calculatedDataTotalChildCareCost,&#10; totalFamilyIncome: calculatedDataTotalFamilyIncome,&#10; transportationCost: calculatedDataTotalTransportationAllowance,&#10; miscellaneousAllowance: calculatedDataMiscellaneousAllowance,&#10; totalAssessmentNeed: calculatedDataTotalAssessedNeed,&#10; totalAcademicExpenses: calculatedDataTotalAcademicExpenses,&#10; finalFederalAwardNetCSGPAmount: finalFederalAwardNetCSGPAmount,&#10; finalFederalAwardNetCSPTAmount: finalFederalAwardNetCSPTAmount,&#10; finalFederalAwardNetCSGDAmount: finalFederalAwardNetCSGDAmount,&#10; finalProvincialAwardNetBCAGAmount: finalProvincialAwardNetBCAGAmount,&#10; finalProvincialAwardNetSBSDAmount: finalProvincialAwardNetSBSDAmount,&#10; finalFederalAwardNetCSLPAmount: finalFederalAwardNetCSLPAmount,&#10; finalAwardTotal: finalAwardTotal&#10;}" target="assessmentData" />
<zeebe:input source="={&#10; weeks: offeringWeeks,&#10; tuitionCost: calculatedDataActualTuitionCosts,&#10; booksAndSuppliesCost: calculatedDataProgramRelatedCosts,&#10; mandatoryFees: calculatedDataMandatoryFees,&#10; exceptionalEducationCost: offeringExceptionalExpenses,&#10; childcareCost: calculatedDataTotalChildCareCost,&#10; totalFamilyIncome: calculatedDataTotalFamilyIncome,&#10; transportationCost: calculatedDataTotalTransportationAllowance,&#10; miscellaneousAllowance: calculatedDataMiscellaneousAllowance,&#10; totalAssessmentNeed: calculatedDataTotalAssessedNeed,&#10; totalAcademicExpenses: calculatedDataTotalAcademicExpenses,&#10; finalFederalAwardNetCSGPAmount: finalFederalAwardNetCSGPAmount,&#10; finalFederalAwardNetCSPTAmount: finalFederalAwardNetCSPTAmount,&#10; finalFederalAwardNetCSGDAmount: finalFederalAwardNetCSGDAmount,&#10; finalProvincialAwardNetBCAGAmount: finalProvincialAwardNetBCAGAmount,&#10; finalProvincialAwardNetSBSDAmount: finalProvincialAwardNetSBSDAmount,&#10; finalFederalAwardNetCSLPAmount: finalFederalAwardNetCSLPAmount,&#10; finalAwardTotal: finalAwardTotal&#10;}" target="assessmentData" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we require the exceptional expense for the PT assessment data at all?
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not require it in the NOA but we do for some data inventory reports (that may be removed in the future).
I would not remove it right now.

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just a minor question. No blockers.

@guru-aot guru-aot self-requested a review November 1, 2024 22:26
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Nice work @andrewsignori-aot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Camunda Worflow Involves camunda workflow changes Student Student Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants