Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3866 - Parse the last 2 characters in NEB as decimal places. #3872

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Oct 31, 2024

SFAS Import update on NEB

  • NEB: Logic for parsing NEB updated to consider the last 2 characters as decimals.
  • BCGG: Verified that the logic for parsing BCGG is not considering decimals.(No code change here)
  • Verified the part time applications in import are NOT considering decimals during the parsing of amounts.
  • Verified the full time applications in import are considering last 2 characters as decimals during the parsing of amounts.

E2E Tests

  • Adjusted the E2E tests according to updated NEB logic.

Manual Test

Imported records with NEB successfully

image

@dheepak-aot dheepak-aot added the Hotfix PR created for hotfix label Nov 1, 2024
Copy link

sonarqubecloud bot commented Nov 1, 2024

Copy link

github-actions bot commented Nov 1, 2024

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.9% ( 3495 / 15960 )
Methods: 9.89% ( 197 / 1991 )
Lines: 25.59% ( 3081 / 12039 )
Branches: 11.24% ( 217 / 1930 )

Copy link

github-actions bot commented Nov 1, 2024

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 58.64% ( 509 / 868 )
Methods: 52.88% ( 55 / 104 )
Lines: 62.27% ( 411 / 660 )
Branches: 41.35% ( 43 / 104 )

Copy link

github-actions bot commented Nov 1, 2024

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.09% ( 1058 / 1229 )
Methods: 87.3% ( 110 / 126 )
Lines: 87.08% ( 903 / 1037 )
Branches: 68.18% ( 45 / 66 )

Copy link

github-actions bot commented Nov 1, 2024

E2E SIMS API Coverage Report

Totals Coverage
Statements: 65.62% ( 5524 / 8418 )
Methods: 63.14% ( 680 / 1077 )
Lines: 69.75% ( 4367 / 6261 )
Branches: 44.17% ( 477 / 1080 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@andrewsignori-aot andrewsignori-aot changed the title 3866 - Parse the last 2 characters in NEB as decimal places. #3866 - Parse the last 2 characters in NEB as decimal places. Nov 1, 2024
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @dheepak-aot 👍

@dheepak-aot dheepak-aot merged commit 20389ad into hotfix/v1.14.1 Nov 1, 2024
20 checks passed
@dheepak-aot dheepak-aot deleted the fix/3866-neb-bcgg branch November 4, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hotfix PR created for hotfix Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants