#3825 - Virus Scanning - Empty File Check #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsignori-aot
added
Queue Consumers
Security-related
andrewsignori-aot
changed the title
guru-aot
reviewed
Oct 31, 2024
| studentFile.uniqueFileName, | ||
| ); | ||
| if (contentLength === 0) { |
There was a problem hiding this comment.
👍 , the contentLength was already available in the objectStorageService. Good
guru-aot
approved these changes
Oct 31, 2024
dheepak-aot
reviewed
Oct 31, 2024
| @@ -36,7 +39,7 @@ export class VirusScanProcessor { | |||
| } catch (error: unknown) { | |||
| if (error instanceof CustomNamedError) { | |||
| const errorMessage = error.message; | |||
| if (error.name === FILE_NOT_FOUND) { | |||
| if ([FILE_NOT_FOUND, EMPTY_FILE].includes(error.name)) { | |||
There was a problem hiding this comment.
Very minor. please update the comment underneath.
There was a problem hiding this comment.
Makes sense, updated.
dheepak-aot
reviewed
Oct 31, 2024
Comment on lines
+59
to
+63
| // Empty files are not suitable for virus scanning using passthrough. | ||
| throw new CustomNamedError( | ||
| `File ${uniqueFileName} has no content to be scanned.`, | ||
| EMPTY_FILE, | ||
| ); |
dheepak-aot
reviewed
Oct 31, 2024
| */ | ||
| export function createFakeGetObjectResponse(fileContent: string): jest.Mock { | ||
| return jest.fn(() => { | ||
| const buffer = Buffer.from(fileContent); |
dheepak-aot
approved these changes
Oct 31, 2024
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a socket to send a file content to
clamavusing the passthrough and no content is sent, the connection stays open for an indefinite amount of time (over 5 minutes).Changed queue-consumers to throw an error and remove the job, same behavior when the file is not found.
We can have a separate ticket to apply validation for the file upload to avoid accepting empty files, but I considered it outside this hotfix issue.
ClamAV debug log when a empty file is send for scanning.