#3738 - E2E Tests SIMS to SFAS #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidyashish
requested changes
Oct 29, 2024
...rocessors/schedulers/sfas-integration/_tests_/sims-to-sfas-integration.scheduler.e2e-spec.ts
Show resolved
Hide resolved
...rocessors/schedulers/sfas-integration/_tests_/sims-to-sfas-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
...rocessors/schedulers/sfas-integration/_tests_/sims-to-sfas-integration.scheduler.e2e-spec.ts
Show resolved
Hide resolved
...rocessors/schedulers/sfas-integration/_tests_/sims-to-sfas-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
bidyashish
reviewed
Oct 29, 2024
...rocessors/schedulers/sfas-integration/_tests_/sims-to-sfas-integration.scheduler.e2e-spec.ts
Show resolved
Hide resolved
| /** | ||
| * Add milliseconds to a given date. | ||
| * @param yearsToAdd number of years to be added. | ||
| * @param date date. |
There was a problem hiding this comment.
Double white space.
Same for both methods.
|
|
||
| beforeEach(async () => { | ||
| // Reset all SFAS bridge logs. | ||
| await db.sfasBridgeLog.delete({ id: MoreThan(0) }); |
There was a problem hiding this comment.
We also use truncate for these situations, as below:
...rocessors/schedulers/sfas-integration/_tests_/sims-to-sfas-integration.scheduler.e2e-spec.ts
Show resolved
Hide resolved
| expect(footer).toBe("999000000001"); | ||
| expect(studentRecord).toBe(buildStudentRecord(student)); | ||
| // Check the database for creation of SFAS bridge log. | ||
| const uploadedFileLog = await db.sfasBridgeLog.findOneBy({ |
There was a problem hiding this comment.
We have been using exists also for these types of checks.
| }, | ||
| ); | ||
|
|
||
| it( |
There was a problem hiding this comment.
Can we be consistent about where the white space goes? This description was added twice. I would recommend adding to the end of the lines only.
andrewsignori-aot
approved these changes
Oct 29, 2024
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIMS TO SFAS E2E TESTS
TEST SCENARIOS
New Library for mocking the current date retuned by the code
new Date()) returned, a new library mockdate has been added.