#3260 - CAS Integration 3A - Create new Supplier and Site - Name Fix And Error Log Improvement #3843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sources/packages/backend/libs/integrations/src/cas/_tests_/unit/cas-test.utils.ts
Dismissed
Show dismissed
Hide dismissed
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
dheepak-aot
reviewed
Oct 28, 2024
| supplierData.firstName, | ||
| supplierData.lastName, |
dheepak-aot
reviewed
Oct 28, 2024
Comment on lines
+16
to
+18
| const formattedName = `${lastName}, ${firstName}` | ||
| .substring(0, CAS_SUPPLIER_NAME_MAX_LENGTH) | ||
| .trim(); |
E2E SIMS API Coverage Report
|
guru-aot
reviewed
Oct 28, 2024
| * Initializes the service under test. | ||
| * @returns array of mocked services. | ||
| */ | ||
| export async function initializeService(): Promise< |
guru-aot
reviewed
Oct 28, 2024
| !!error.response?.data[CAS_RETURNED_MESSAGES] | ||
| ) { | ||
| // Checking for bad request errors for better logging while the | ||
| // specific ticket to handle exception is pending. |
guru-aot
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample logged error (Invalid SIN).