Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3620 - Change Request - Partner Current Year Income (financial information) option (Fix Duplicate Markup) #3834

Conversation

lewischen-aot
Copy link
Collaborator

Fixed duplicates of the markup content in the Upload Document panel in the Form.io file.

Screenshot of the markup content before the fix
image

Screenshot of the markup content after the fix
image

@lewischen-aot lewischen-aot self-assigned this Oct 24, 2024
@lewischen-aot lewischen-aot added the Form.io Form IO definitions changed. label Oct 24, 2024
Copy link

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.54% ( 3657 / 16223 )
Methods: 10.11% ( 204 / 2017 )
Lines: 25.95% ( 3179 / 12252 )
Branches: 14.02% ( 274 / 1954 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 58.64% ( 509 / 868 )
Methods: 52.88% ( 55 / 104 )
Lines: 62.27% ( 411 / 660 )
Branches: 41.35% ( 43 / 104 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 83.18% ( 1157 / 1391 )
Methods: 83.94% ( 115 / 137 )
Lines: 84.22% ( 987 / 1172 )
Branches: 67.07% ( 55 / 82 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.01% ( 5571 / 8439 )
Methods: 63.3% ( 683 / 1079 )
Lines: 70.12% ( 4401 / 6276 )
Branches: 44.93% ( 487 / 1084 )

@lewischen-aot lewischen-aot changed the title #3620 - Change Request - Partner Current Year Income (financial information) option (Fix Upload Markup) #3620 - Change Request - Partner Current Year Income (financial information) option (Fix Duplicate Markup) Oct 24, 2024
@lewischen-aot lewischen-aot marked this pull request as ready for review October 24, 2024 17:59
Copy link
Collaborator

@bidyashish bidyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👍

@lewischen-aot lewischen-aot added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 4e37d78 Oct 24, 2024
20 checks passed
@lewischen-aot lewischen-aot deleted the fix/#3620-change-request-partner-current-year-income-upload-doc branch October 25, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Form.io Form IO definitions changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants