-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3738 - SIMS to SFAS Part 2 #3829
Conversation
sources/packages/backend/libs/integrations/src/sfas-integration/sfas-integration.models.ts
Show resolved
Hide resolved
sources/packages/backend/libs/integrations/src/sfas-integration/sfas-integration.models.ts
Show resolved
Hide resolved
.../packages/backend/libs/integrations/src/sfas-integration/sims-to-sfas.integration.service.ts
Outdated
Show resolved
Hide resolved
.../packages/backend/libs/integrations/src/sfas-integration/sims-to-sfas.integration.service.ts
Outdated
Show resolved
Hide resolved
...ackend/libs/integrations/src/sfas-integration/sims-sfas-files/sims-to-sfas-student-record.ts
Outdated
Show resolved
Hide resolved
...s/backend/libs/integrations/src/sfas-integration/sims-sfas-files/sims-to-sfas-base.record.ts
Show resolved
Hide resolved
...ckages/backend/libs/integrations/src/sfas-integration/sims-sfas-files/sims-to-sfas-header.ts
Outdated
Show resolved
Hide resolved
...end/libs/integrations/src/sfas-integration/sims-sfas-files/sims-to-sfas-file-line-builder.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and great start to the SFAS bridge. Looks good 👍
// Check if the student data was updated in the given period. | ||
.andWhere( | ||
new Brackets((qb) => { | ||
qb.where( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
[ | ||
"Process finalized with success.", | ||
`Student records sent: ${studentRecordsSent}`, | ||
`Uploaded file name: ${uploadedFileName}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add a period at the end??
.appendHeader(bridgeFileDate) | ||
.appendStudentFileRecords(studentRecords) | ||
.appendFooter().fileLines; | ||
// TODO: SIMS to SFAS - Append applications, restrictions and footer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
// Append the students with student and student related data updates. | ||
// TODO: SIMS to SFAS - Append the student ids of students with updates in application and restriction related data. | ||
// When application and restriction updates are retrieved, the respective | ||
// student ids of applications and restrictions should be appended.; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the semi colon at the end
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work @dheepak-aot
SIMS TO SFAS - INTEGRATION IMPLEMENTATION FOR STUDENT DATA RECORDS
ENV
SFAS_SEND_FOLDER
. Declared it as github env, not as secret.PROCESS
File generated with following name structure
SIMS-TO-SFAS-YYYYMMDD-HHMMSS.TXT
Student data is retrieved to build the file for all students who has one or more of the following updates since last run date.
Students with at least one submitted application are considered to extract the data. As submitted applications can be cancelled and also the Draft applications can be cancelled, application status NOT Draft could be tricky. So used the condition of application with current assessment NOT NULL to identify a submitted application.
When one or more students with updates are present, then a file is produced and sent to SFAS SFTP location.
Summary:
Process Logs:
Summary:
Process Logs:
TECHNICAL CONTEXT
TODO: SIMS to SFAS
in the code.