#3260 - CAS Integration 3A - Create new Supplier and Site - Refactor CAS authentication #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...es/backend/libs/integrations/src/cas/_tests_/unit/cas.service.getSupplierInfoFromCAS.spec.ts
Dismissed
Show dismissed
Hide dismissed
dheepak-aot
reviewed
Oct 23, 2024
...cas-supplier/cas-evaluation-result-processor/cas-active-supplier-and-site-found-processor.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
Oct 23, 2024
...services/cas-supplier/cas-evaluation-result-processor/cas-active-supplier-found-processor.ts
Show resolved
Hide resolved
| /** | ||
| * Cache the CAS token to be reused. | ||
| */ | ||
| export class CachedCASAuthDetails { |
There was a problem hiding this comment.
I'm not sure if this class should be in a model file. I'd rather have it in cas.service.ts or have a new file for CachedCASAuthDetails.
There was a problem hiding this comment.
Move to a different file.
dheepak-aot
reviewed
Oct 23, 2024
sources/packages/backend/libs/integrations/src/cas/models/cas-service.model.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Oct 23, 2024
| * Default amount of time to a token be expired and be | ||
| * considered candidate to be renewed. | ||
| */ | ||
| const CAS_TOKEN_RENEWAL_SECONDS = 60; |
There was a problem hiding this comment.
in system configuration constants ?
There was a problem hiding this comment.
I do not see a value in moving this. It is a private const only used to create some difference for the actual expiration time.
dheepak-aot
reviewed
Oct 23, 2024
...processors/schedulers/cas-integration/_tests_/cas-supplier-integration.scheduler.e2e-spec.ts
Outdated
Show resolved
Hide resolved
|
Thanks for making this refactor to simplify the CAS logon call. Please have a look at the comments. |
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
dheepak-aot
approved these changes
Oct 23, 2024
andrepestana-aot
approved these changes
Oct 23, 2024
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As agreed in the previous PR, the CAS authentication is now encapsulated inside the CAS API service and the auth token no longer needs to be passed to every method.
The current CAS token expiration is set to 1 hour and the token will be considered "about to expire" one minute before it.