Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Rollback File #3821

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Fixed Rollback File #3821

merged 3 commits into from
Oct 23, 2024

Conversation

sh16011993
Copy link
Collaborator

@sh16011993 sh16011993 commented Oct 23, 2024 •
edited
Loading

Expected Behavior

npm run migration:revert should be executed successfully in all release planned migrations.

Fix: Filename corrected: Rollback-insert-student-notification-pd-ppd-student-reminder.sql

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.42% ( 3634 / 16208 )
Methods: 9.98% ( 201 / 2014 )
Lines: 25.81% ( 3160 / 12243 )
Branches: 13.99% ( 273 / 1951 )

@sh16011993 sh16011993 self-assigned this Oct 23, 2024
@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 58.64% ( 509 / 868 )
Methods: 52.88% ( 55 / 104 )
Lines: 62.27% ( 411 / 660 )
Branches: 41.35% ( 43 / 104 )

@sh16011993 sh16011993 added Bug Something isn't working Release Branch Merge High Priority Priority ticket for grooming labels Oct 23, 2024
@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 83.21% ( 1160 / 1394 )
Methods: 83.94% ( 115 / 137 )
Lines: 84.26% ( 990 / 1175 )
Branches: 67.07% ( 55 / 82 )

@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.01% ( 5571 / 8439 )
Methods: 63.3% ( 683 / 1079 )
Lines: 70.12% ( 4401 / 6276 )
Branches: 44.93% ( 487 / 1084 )

andrewsignori-aot
andrewsignori-aot approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sh16011993 sh16011993 added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit ddfb454 Oct 23, 2024
52 checks passed
@sh16011993 sh16011993 deleted the release/v1.14.0 branch October 23, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

Assignees

@sh16011993 sh16011993

Labels
Bug Something isn't working High Priority Priority ticket for grooming Release Branch Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sh16011993 @andrewsignori-aot @bidyashish