Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3620 - Change Request - Partner Current Year Income (financial information) option (Quick Fix) #3820

Merged

Conversation

lewischen-aot
Copy link
Collaborator

@lewischen-aot lewischen-aot commented Oct 23, 2024

  • Modified maxMoneyValue in Form.io definition "partnerinformationandincomeappeal.json" to fix the backend error due to failure in Form.io dryRun validation in my previous while submitting an appeal.
    • Unchecked "table view"
    • Checked "Calculate on server"

Screenshot of backend error due to Form.io definition
image

Screenshot of successful backend log with the current change
image

@lewischen-aot lewischen-aot added the Form.io Form IO definitions changed. label Oct 23, 2024
@lewischen-aot lewischen-aot self-assigned this Oct 23, 2024
Copy link

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.42% ( 3634 / 16208 )
Methods: 9.98% ( 201 / 2014 )
Lines: 25.81% ( 3160 / 12243 )
Branches: 13.99% ( 273 / 1951 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 58.64% ( 509 / 868 )
Methods: 52.88% ( 55 / 104 )
Lines: 62.27% ( 411 / 660 )
Branches: 41.35% ( 43 / 104 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 83.21% ( 1160 / 1394 )
Methods: 83.94% ( 115 / 137 )
Lines: 84.26% ( 990 / 1175 )
Branches: 67.07% ( 55 / 82 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.01% ( 5571 / 8439 )
Methods: 63.3% ( 683 / 1079 )
Lines: 70.12% ( 4401 / 6276 )
Branches: 44.93% ( 487 / 1084 )

@lewischen-aot lewischen-aot marked this pull request as ready for review October 23, 2024 19:33
@dheepak-aot dheepak-aot self-requested a review October 23, 2024 19:41
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👍

@lewischen-aot lewischen-aot added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 3ef2b29 Oct 23, 2024
20 checks passed
@lewischen-aot lewischen-aot deleted the fix/#3620-change-request-partner-current-year-income branch October 23, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Form.io Form IO definitions changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants