#3697 - View Assessment Updates #3813
Conversation
lewischen-aot
added
Enhancement
| offeringIntensity: OfferingIntensity.partTime, | ||
| }, | ||
| ]; | ||
|
|
||
| export const PartTimeAwardTypesObject = { |
| @@ -1,7 +1,7 @@ | |||
| <template> | |||
| <body-header | |||
| title="Summary" | |||
| subTitle="Below is the summary from your assessment. To view your entire assessment, click on View assessment." | |||
There was a problem hiding this comment.
Should this period in the end to be removed?
There was a problem hiding this comment.
I think it's fine to keep the period. The AC is to replace the sentence, and it makes sense to keep the period at the end for a sentence.
There was a problem hiding this comment.
The image in AC says that period is retained.
There was a problem hiding this comment.
I thought there was a period at the end, but there wasn't. It's updated.
| @@ -55,22 +55,22 @@ export const AWARDS: AwardDetail[] = [ | |||
| }, | |||
| { | |||
| awardType: PartTimeAwardTypes.CSLP, | |||
| description: "Canada Student Loan for Part-time Studies", | |||
| description: "Canada Student Loan for Part-Time Students", | |||
There was a problem hiding this comment.
Part-time with lower case "t".
There was a problem hiding this comment.
I know the AC has upper-case but all the system uses lower case. Please check.
There was a problem hiding this comment.
Nice catch. It's this one place where "time" is capitalized. It's now updated.
|
Nice work @lewischen-aot. Please take a look at the comments. |
| if (awardValue === undefined) { | ||
| return "(Not eligible)"; | ||
| } | ||
| return getFormattedAwardValue(awardValue); |
There was a problem hiding this comment.
As we know that the dynamic award value with key as award name is definitely a number, I would say we can force cast it. like this.
const awardValue = props.awardDetails[
`${props.identifier}${awardType.toLowerCase()}`
] as number;It will allow us to set the type of award value as number.
|
Thanks for making the changes. Just few minor comments. |
| if (awardValue === undefined) { | ||
| return "(Not eligible)"; | ||
| } | ||
| return getFormattedMoneyValue(awardValue); |
There was a problem hiding this comment.
return awardValue === undefined ? getFormattedMoneyValue(awardValue) : "(Not eligible)";
There was a problem hiding this comment.
It is the opposite @andrepestana-aot when undefined "(Not eligible)" needs to return. Are you saying this as a suggestion?
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Screenshot for the first disbursement for part-time applications
Screenshot for the first disbursement for full-time applications
