Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2621 - Notice of Assessment Updates #3801

Merged
merged 15 commits into from
Oct 22, 2024
Merged

#2621 - Notice of Assessment Updates #3801

merged 15 commits into from
Oct 22, 2024

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Oct 17, 2024 •
edited
Loading

image

  • Updated NOA as per FIGMA layout;
  • Formatted currency to $##,###.00 format;
  • Updated assessment costs:
    • order;
    • tooltips;
    • layout to fit the columns;
  • Changed date format to "MMMM D, YYYY";
  • Updated to dynamically display:
    • "Your Part-time MSFAA number:";
    • "Your cancelled Part-time MSFAA number:";
    • "Your new Part-time MSFAA number:";
  • Duplicated buttons and added a red color to the Cancel application button;
  • Second disbursements now are show dynamically.

@andrepestana-aot andrepestana-aot self-assigned this Oct 17, 2024
@andrepestana-aot andrepestana-aot added Student Student Features Form.io Form IO definitions changed. labels Oct 17, 2024
@andrepestana-aot andrepestana-aot marked this pull request as ready for review October 21, 2024 20:10
@lewischen-aot lewischen-aot self-requested a review October 21, 2024 20:58
andrewsignori-aot
andrewsignori-aot reviewed Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great UI review. Please take a look at the comments.

lewischen-aot
lewischen-aot reviewed Oct 22, 2024
View reviewed changes
sources/packages/forms/src/form-definitions/noticeofassessment.json Outdated
@@ -17081,7 +17080,7 @@
"value": ""
}
],
"content": "If you’ve had a loan in the last 2 years from StudentAid BC, or have a valid MSFAA on file, you do not need to submit an MSFAA.",
"content": "Please accept your assessment to move your application forward. Please ensure your banking information is up to date by logging in to your <strong>\n <a \n class=\"primary-color\"\n href=\"https://protege-secure.csnpe-nslsc.canada.ca/en/public/sign-in-method\"\n target=\"_blank\"\n rel=\"noopener noreferrer\"\n >National Student Loan Service Centre account</a\n >\n </strong> if your banking information is not up to date, you may not receive your funding.",
Copy link
Collaborator

@lewischen-aot lewischen-aot Oct 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is just a tiny spot. It would be great if we add a period . after "account", capitalize i and put bold text to "accept" like shown below.
image

It looks like FIGMA image is missing a period . after "account" as well.
image

This is not a blocker comment by the way.

lewischen-aot
lewischen-aot approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@lewischen-aot lewischen-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 👍 Nice work @andrepestana-aot

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.42% ( 3634 / 16208 )
Methods: 9.98% ( 201 / 2014 )
Lines: 25.81% ( 3160 / 12243 )
Branches: 13.99% ( 273 / 1951 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 58.64% ( 509 / 868 )
Methods: 52.88% ( 55 / 104 )
Lines: 62.27% ( 411 / 660 )
Branches: 41.35% ( 43 / 104 )

@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 83.21% ( 1160 / 1394 )
Methods: 83.94% ( 115 / 137 )
Lines: 84.26% ( 990 / 1175 )
Branches: 67.07% ( 55 / 82 )

andrewsignori-aot
andrewsignori-aot approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, looks good 👍

@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.01% ( 5571 / 8439 )
Methods: 63.3% ( 683 / 1079 )
Lines: 70.12% ( 4401 / 6276 )
Branches: 44.93% ( 487 / 1084 )

@andrepestana-aot andrepestana-aot added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 3605f84 Oct 22, 2024
20 checks passed
@andrepestana-aot andrepestana-aot deleted the 2621_notice_of_assessment_updates branch November 1, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewischen-aot lewischen-aot lewischen-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

Assignees

@andrepestana-aot andrepestana-aot

Labels
Form.io Form IO definitions changed. Student Student Features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrepestana-aot @andrewsignori-aot @lewischen-aot