Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3620 - Change Request - Partner Current Year Income (financial information) option #3799

Merged
merged 11 commits into from
Oct 23, 2024
Merged

#3620 - Change Request - Partner Current Year Income (financial information) option #3799

merged 11 commits into from
Oct 23, 2024

Conversation

lewischen-aot
Copy link
Collaborator

@lewischen-aot lewischen-aot commented Oct 16, 2024 •
edited
Loading

  • Added a new question to the Partner Information and Income to allow students to submit partner income for the current year.
  • Replaced "YEAR" with dynamic outcome with following logic:
  • Updated the Camunda workflow to reflect new priority list for partner income.
  • Moved the "Define partner income" in the workflow after the appeals to use the appeals' calculated variables
  • Converted the current logic inside "Define Partner Income" to a flow
  • Created E2E tests for partner current year income.
    • For API: "Should save the current year partner income when the student submits an appeal for the current year partner income."
    • For workflow: "Should calculate partner income as current year partner income value when there is a request a change for current year partner income."

Screenshots of current year partner income UI
image

image

Screenshot of Camunda workflow
image

@lewischen-aot lewischen-aot self-assigned this Oct 16, 2024
@lewischen-aot lewischen-aot added the Camunda Worflow Involves camunda workflow changes label Oct 16, 2024
@lewischen-aot lewischen-aot marked this pull request as ready for review October 17, 2024 19:59
@guru-aot guru-aot self-requested a review October 17, 2024 20:46
@dheepak-aot dheepak-aot self-requested a review October 17, 2024 20:46
dheepak-aot
dheepak-aot reviewed Oct 17, 2024
View reviewed changes
sources/packages/forms/src/form-definitions/studentfinancialinformationappeal.json Outdated
"tableView": false,
"components": [
{
"label": "Please explain your situation:",
Copy link
Collaborator

@dheepak-aot dheepak-aot Oct 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be
image

Please confirm with business.

@dheepak-aot
Copy link
Collaborator

Please have a look at the comments.

@andrewsignori-aot andrewsignori-aot mentioned this pull request Oct 18, 2024
Merged
@dheepak-aot
Copy link
Collaborator

Great job @lewischen-aot. Thanks for making the changes. Added more comments.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.42% ( 3632 / 16201 )
Methods: 9.99% ( 201 / 2013 )
Lines: 25.8% ( 3158 / 12238 )
Branches: 14% ( 273 / 1950 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 58.64% ( 509 / 868 )
Methods: 52.88% ( 55 / 104 )
Lines: 62.27% ( 411 / 660 )
Branches: 41.35% ( 43 / 104 )

@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 83.21% ( 1160 / 1394 )
Methods: 83.94% ( 115 / 137 )
Lines: 84.26% ( 990 / 1175 )
Branches: 67.07% ( 55 / 82 )

dheepak-aot
dheepak-aot approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes. Looks good. 👍

@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.01% ( 5571 / 8439 )
Methods: 63.3% ( 683 / 1079 )
Lines: 70.12% ( 4401 / 6276 )
Branches: 44.93% ( 487 / 1084 )

guru-aot
guru-aot approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @lewischen-aot

@lewischen-aot lewischen-aot added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit fe802ca Oct 23, 2024
20 checks passed
@lewischen-aot lewischen-aot deleted the feature/#3620-change-request-partner-current-year-income branch October 23, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guru-aot guru-aot guru-aot approved these changes

@dheepak-aot dheepak-aot dheepak-aot approved these changes

Assignees

@lewischen-aot lewischen-aot

Labels
Camunda Worflow Involves camunda workflow changes E2E/Unit tests Form.io Form IO definitions changed. Student Student Features Supporting User User Story
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewischen-aot @dheepak-aot @guru-aot