#3748 - Content - Student current year income dynamic year #3791
Conversation
bidyashish
added
Student
| "properties": {}, | ||
| "customClass": "", | ||
| "lockKey": true, | ||
| "calculateValue": "value = data.programYear ? data.programYear: \"\";" |
There was a problem hiding this comment.
If data.programYear already has the desired value, is there a need to create a second hidden field?
There was a problem hiding this comment.
Yes, I have tried to separate data.programYear with 'Current tax Tear', so I have defined new Current tax year hidden value. Just in case if we need know Current tax year is fetched.
There was a problem hiding this comment.
About the justification "Just in case if we need know Current tax year is fetched", when that would be a benefit since this is only used to be displayed in some labels and is derived from the program year?
There was a problem hiding this comment.
In this case, 'data.programYear' gives first year of program year like '2024', which is the required value for Current tax year. I was thinking to use separate variable name of Current tax year rather than use same data.programYear as variable name is not as per the required Current tax year to follow standardization.
| "input": true, | ||
| "tableView": true, | ||
| "key": "currentTaxYear", | ||
| "label": "currentTaxYear", |
There was a problem hiding this comment.
Minor, the label can follow the same pattern as the exiting ones (e.g. Current Tax Year).
| "label": "currentTaxYear", | ||
| "protected": false, | ||
| "unique": false, | ||
| "persistent": true, |
There was a problem hiding this comment.
Please set the persistent to false.
| @@ -279,7 +298,7 @@ | |||
| "value": "" | |||
| } | |||
| ], | |||
| "content": "If you have had, or anticipate having a significant decrease in income for {{data.calculatedTaxYear}}, you may request to be assessed using this year's estimated income.", | |||
| "content": "If you have had, or anticipate having a significant decrease in income for {{data.currentTaxYear}}, you may request to be assessed using this year's estimated income.", | |||
There was a problem hiding this comment.
Please use data.programYear, or please explain why this was not used.
There was a problem hiding this comment.
Yes, I have tried to separate data.programYear with 'Current tax Tear', so I have defined new Current tax year hidden value. Just in case if we need know Current tax year is being fetched.
There was a problem hiding this comment.
The data.programYear in this form is not actually the "2024-2025" program year name?
If I am right the question from @guru-aot would not make sense and and reply from @bidyashish should probably mention it. Please let me know if I am missing something.
There was a problem hiding this comment.
yes thats correct, data.programYear gives '2024-2025' as Program year, I used the the similar logic as calculatedTaxYear to get Current Tax Year.
There was a problem hiding this comment.
Nice work @bidyashish , please have a look on the comments.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
bidyashish
deleted the
feature/#3748-Content-update-income-year-dynamic
branch
Below AC were Done previously and not needed any more as part of this PR.