#3738 - SIMS To SFAS Bridge DB Migrations and Scheduler Setup #3785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
6
to
7
| created_at TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT NOW(), | ||
| creator INT NULL DEFAULT NULL REFERENCES sims.users(id) |
There was a problem hiding this comment.
Is there a value in adding these columns?
I would not mind having them removed or maybe the creator removed.
There was a problem hiding this comment.
I have these columns as the System is inserting this data. Please let me know if there is a downside of having them.
There was a problem hiding this comment.
For the created_at I see a benefit. For the creator it will always be the system. I do not see a reason to keep the creator. Since it is a SFAS table it would not be a blocker.
There was a problem hiding this comment.
Removed creator is removed. And rollback tested.
...e-consumers/src/processors/schedulers/sfas-integration/sims-to-sfas-integration.scheduler.ts
Outdated
Show resolved
Hide resolved
...e-consumers/src/processors/schedulers/sfas-integration/sims-to-sfas-integration.scheduler.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/libs/sims-db/src/entities/sfas-bridge-log.model.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/libs/sims-db/src/entities/sfas-bridge-log.model.ts
Outdated
Show resolved
Hide resolved
bidyashish
reviewed
Oct 10, 2024
sources/packages/backend/apps/db-migrations/src/sql/Queue/Add-sims-to-sfas-integration.sql
Show resolved
Hide resolved
bidyashish
approved these changes
Oct 11, 2024
|
Backend Unit Tests Coverage Report
|
andrewsignori-aot
approved these changes
Oct 11, 2024
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIMS To SFAS Bridge DB Migrations and Scheduler Setup
DB Migration
sims.sfas_bridge_logs(Table name modified to plural and the column for file name little different in comparison with technical AC).sims.sfas_bridge_logshas only creation respective audit columns as it is never expected to receive update.sims-to-sfas-integration. It is scheduled to run at12:00 AM 4:00 AM 8:00 AM 12:00 PM 12:00 AM 4:00 PM 8:00 AMwith cron expression0 0,4,8,12,16,20 * * *Rollback Evidence