#3721 - PT Assessment - Books and Supplies Limit #3771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sources/packages/backend/workflow/src/workflow-definitions/parttime-assessment-decisions.dmn
Show resolved
Hide resolved
| @@ -8,8 +8,8 @@ ARG FORMIO_SOURCE_REPO_TAG | |||
| # Note: using pinned versions to ensure immutable build environment. | |||
| RUN apk update && \ | |||
| apk upgrade && \ | |||
| apk add make=4.4.1-r2 && \ | |||
| apk add python3=3.12.6-r0 && \ | |||
| apk add make && \ | |||
There was a problem hiding this comment.
Thanks for taking care of this. I would suggest removing the version from the other packages also (lines 13 and 14).
andrewsignori-aot
approved these changes
Oct 10, 2024
Comment on lines
9
to
12
| it( | ||
| "Should use minimum (offering program related costs) " + | ||
| "when dmn limit for books and supplies * number of offering weeks has a higher value.", | ||
| async () => { |
There was a problem hiding this comment.
Minor suggestion. The test case description is great, but maybe we could use "Should get program related costs as the offering program related costs when the DMN limit for books and supplies multiplied by offering weeks has the greater value."
lewischen-aot
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
LGTM @andrepestana-aot. Just left a minor comment, but a blocker. Great work 👍
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrepestana-aot
deleted the
3721_pt_assessment_books_and_supplies_limit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
limitWeeklyBooksAndSuppliestodmnPartTimeProgramYearMaximums:Changed calculatedDataProgramRelatedCosts to check the minimum between
offeringProgramRelatedCostsanddmnPartTimeProgramYearMaximums.limitWeeklyBooksAndSupplies * offeringWeeks:Added offering delivery "blended" to allow
calculatedDataWeeklyMinTransportto receivedmnPartTimeProgramYearMaximums.limitTransportationAllowance:Added offering delivery "blended" to allow
inputDataRemainingTransportWeeksto receive the value ofofferingWeeks - calculatedDataAdditionalTransportWeeksAdded offering delivery "blended" to allow
calculatedDataTotalTransportationAllowanceto receive the value ofofferingWeeks * dmnPartTimeProgramYearMaximums.limitTransportationAllowanceAdded tests to check program related costs impacted by books and supply costs;
Added tests to check transportation costs when the offering delivery is blended;
Added
calculatedDataTotalAssessedNeedto assessment.model.ts as this variable has a typo for FT and it is correct for PT. Added a TODO to be done in another ticket;Removed the python3 and make versions to fix a problem with local forms container (not related to this ticket).