#1862 - UX/UI for Ignore Restriction - Bypass List #3734

lewischen-aot · 2024-09-23T22:01:38Z

Built a page for when the Ministry selects an application and selects "Restrictions Management" from the left panel.
Created a new link in the left menu named "Restrictions Management".
- Disabled the content card for draft applications.
Create the new list "History of Bypassed Restrictions" (use Vuetify table).
- Ordered the list DESC by creation date (most recent entry on the top).
Created a new API endpoint to obtain the restriction bypasses history
- GET aest/application-restriction-bypass/application/:applicationId
Added E2E tests
- application-restriction-bypass.aest.controller.getApplicationRestrictionBypasses.e2e-spec.ts

Screenshot of the Application Restriction Management page for applications without bypass records

Screenshot of the Application Restriction Management page for applications two bypass records

Screenshots of E2E tests

...ckages/web/src/components/aest/students/bypassedRestrictions/HistoryBypassedRestrictions.vue

...ps/api/src/services/application-restriction-bypass/application-restriction-bypass.service.ts

...controllers/application-restriction-bypass/application-restriction-bypass.aest.controller.ts

.../src/route-controllers/institution-locations/institution-location.institutions.controller.ts

sources/packages/web/src/components/layouts/aest/AESTApplicationSideBar.vue

...controllers/application-restriction-bypass/application-restriction-bypass.aest.controller.ts

sources/packages/web/src/components/layouts/aest/AESTApplicationSideBar.vue

...oute-controllers/application-restriction-bypass/models/application-restriction-bypass.dto.ts

...s/api/src/route-controllers/institution-locations/institution-location.controller.service.ts

...kend/apps/api/src/route-controllers/institution-locations/models/institution-location.dto.ts

.../packages/backend/apps/api/src/services/institution-location/institution-location.service.ts

sources/packages/web/src/services/http/BypassedRestrictionApi.ts

sources/packages/web/src/services/BypassedRestrictionService.ts

sources/packages/web/src/services/http/BypassedRestrictionApi.ts

sources/packages/web/src/services/http/dto/BypassedRestriction.dto.ts

sources/packages/web/src/components/layouts/aest/AESTApplicationSideBar.vue

...ckages/web/src/components/aest/students/bypassedRestrictions/HistoryBypassedRestrictions.vue

sources/packages/backend/apps/api/src/route-controllers/application/models/application.dto.ts

...controllers/application-restriction-bypass/application-restriction-bypass.aest.controller.ts

…pass-list

sources/packages/web/src/services/http/dto/ApplicationRestrictionBypass.dto.ts

...ps/api/src/services/application-restriction-bypass/application-restriction-bypass.service.ts

...packages/web/src/views/aest/student/applicationDetails/ApplicationRestrictionsManagement.vue

sources/packages/web/src/components/generic/StatusChipBypass.vue

dheepak-aot

Thanks for making the changes @lewischen-aot . Looks good 👍

sonarqubecloud · 2024-09-27T21:22:01Z

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-09-27T21:22:44Z

Backend Unit Tests Coverage Report

Totals
Statements:	21.94% ( 3477 / 15849 )
Methods:	9.9% ( 196 / 1979 )
Lines:	25.65% ( 3066 / 11955 )
Branches:	11.23% ( 215 / 1915 )

github-actions · 2024-09-27T21:23:14Z

E2E Workflow Workers Coverage Report

Totals
Statements:	58.64% ( 509 / 868 )
Methods:	52.88% ( 55 / 104 )
Lines:	62.27% ( 411 / 660 )
Branches:	41.35% ( 43 / 104 )

github-actions · 2024-09-27T21:24:46Z

E2E Queue Consumers Coverage Report

Totals
Statements:	84.14% ( 992 / 1179 )
Methods:	83.47% ( 101 / 121 )
Lines:	85.33% ( 849 / 995 )
Branches:	66.67% ( 42 / 63 )

github-actions · 2024-09-27T21:36:49Z

E2E SIMS API Coverage Report

Totals
Statements:	65.03% ( 5439 / 8364 )
Methods:	62.31% ( 668 / 1072 )
Lines:	69.25% ( 4306 / 6218 )
Branches:	43.3% ( 465 / 1074 )

lewischen-aot added 2 commits September 23, 2024 14:20

initial commit

8ea96ce

added another e2e test case

3f3b1fc

lewischen-aot self-assigned this Sep 23, 2024

not available for public institution

f1f0e61

lewischen-aot marked this pull request as ready for review September 23, 2024 23:47

dheepak-aot added SIMS-Api SIMS-Api Web portal E2E/Unit tests labels Sep 24, 2024

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

...ckages/web/src/components/aest/students/bypassedRestrictions/HistoryBypassedRestrictions.vue Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

...ckages/web/src/components/aest/students/bypassedRestrictions/HistoryBypassedRestrictions.vue Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

...ps/api/src/services/application-restriction-bypass/application-restriction-bypass.service.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

...ps/api/src/services/application-restriction-bypass/application-restriction-bypass.service.ts Outdated Show resolved Hide resolved

sh16011993 self-requested a review September 24, 2024 16:35

sh16011993 reviewed Sep 24, 2024

View reviewed changes

...controllers/application-restriction-bypass/application-restriction-bypass.aest.controller.ts Outdated Show resolved Hide resolved

sh16011993 reviewed Sep 24, 2024

View reviewed changes

.../src/route-controllers/institution-locations/institution-location.institutions.controller.ts Outdated Show resolved Hide resolved

sh16011993 reviewed Sep 24, 2024

View reviewed changes

sources/packages/web/src/components/layouts/aest/AESTApplicationSideBar.vue Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

...controllers/application-restriction-bypass/application-restriction-bypass.aest.controller.ts Outdated Show resolved Hide resolved

sh16011993 reviewed Sep 24, 2024

View reviewed changes

sources/packages/web/src/components/layouts/aest/AESTApplicationSideBar.vue Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

...oute-controllers/application-restriction-bypass/models/application-restriction-bypass.dto.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

...oute-controllers/application-restriction-bypass/models/application-restriction-bypass.dto.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

...s/api/src/route-controllers/institution-locations/institution-location.controller.service.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

...kend/apps/api/src/route-controllers/institution-locations/models/institution-location.dto.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

.../packages/backend/apps/api/src/services/institution-location/institution-location.service.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

sources/packages/web/src/services/http/BypassedRestrictionApi.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

sources/packages/web/src/services/BypassedRestrictionService.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

sources/packages/web/src/services/http/BypassedRestrictionApi.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

sources/packages/web/src/services/http/dto/BypassedRestriction.dto.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

sources/packages/web/src/components/layouts/aest/AESTApplicationSideBar.vue Show resolved Hide resolved

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

sources/packages/web/src/components/layouts/aest/AESTApplicationSideBar.vue Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 24, 2024

View reviewed changes

...ckages/web/src/components/aest/students/bypassedRestrictions/HistoryBypassedRestrictions.vue Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 26, 2024

View reviewed changes

sources/packages/backend/apps/api/src/route-controllers/application/models/application.dto.ts Outdated Show resolved Hide resolved

lewischen-aot added 4 commits September 26, 2024 13:58

resovle comments - adjusted ACs and supplemental header

8e0df54

resolve comments - restriction management sidebar

a3a8708

resolve issues - sonar cloud

dcc6c0e

resolve sonar cloud issues

4fad8d2

dheepak-aot reviewed Sep 27, 2024

View reviewed changes

...controllers/application-restriction-bypass/application-restriction-bypass.aest.controller.ts Outdated Show resolved Hide resolved

Merge branch 'main' into feature/#1862-uxui-for-ignore-restriction-by…

34c9ec5

…pass-list

dheepak-aot reviewed Sep 27, 2024

View reviewed changes

sources/packages/web/src/services/http/dto/ApplicationRestrictionBypass.dto.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 27, 2024

View reviewed changes

...ps/api/src/services/application-restriction-bypass/application-restriction-bypass.service.ts Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 27, 2024

View reviewed changes

...packages/web/src/views/aest/student/applicationDetails/ApplicationRestrictionsManagement.vue Outdated Show resolved Hide resolved

dheepak-aot reviewed Sep 27, 2024

View reviewed changes

sources/packages/web/src/components/generic/StatusChipBypass.vue Outdated Show resolved Hide resolved

resolve comments - BypassStatusChipLabelTypes label

34d2025

dheepak-aot approved these changes Sep 27, 2024

View reviewed changes

resolve comments - remove history

59b4d56

lewischen-aot added this pull request to the merge queue Sep 27, 2024

Merged via the queue into main with commit 949d24d Sep 27, 2024
20 checks passed

lewischen-aot temporarily deployed to DEV September 27, 2024 21:57 — with GitHub Actions Inactive

lewischen-aot temporarily deployed to DEV September 27, 2024 21:58 — with GitHub Actions Inactive

lewischen-aot temporarily deployed to DEV September 27, 2024 22:01 — with GitHub Actions Inactive

lewischen-aot deleted the feature/#1862-uxui-for-ignore-restriction-bypass-list branch September 27, 2024 22:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1862 - UX/UI for Ignore Restriction - Bypass List #3734

#1862 - UX/UI for Ignore Restriction - Bypass List #3734

lewischen-aot commented Sep 23, 2024 •

edited

Loading

dheepak-aot left a comment

sonarqubecloud bot commented Sep 27, 2024

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 27, 2024

#1862 - UX/UI for Ignore Restriction - Bypass List #3734

#1862 - UX/UI for Ignore Restriction - Bypass List #3734

Conversation

lewischen-aot commented Sep 23, 2024 • edited Loading

dheepak-aot left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Sep 27, 2024

Quality Gate passed

github-actions bot commented Sep 27, 2024

Backend Unit Tests Coverage Report

github-actions bot commented Sep 27, 2024

E2E Workflow Workers Coverage Report

github-actions bot commented Sep 27, 2024

E2E Queue Consumers Coverage Report

github-actions bot commented Sep 27, 2024

E2E SIMS API Coverage Report

lewischen-aot commented Sep 23, 2024 •

edited

Loading