Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2383 - Horizonatal Autoscaler value change #2516

Merged
merged 1 commit into from
Nov 17, 2023
Merged

#2383 - Horizonatal Autoscaler value change #2516

merged 1 commit into from
Nov 17, 2023

Conversation

guru-aot
Copy link
Collaborator

Horizonatal Autoscaler value change from average value to CPU utilization

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@guru-aot guru-aot self-assigned this Nov 17, 2023
@guru-aot guru-aot added the Devops Devops label Nov 17, 2023
@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 19.99% ( 2612 / 13065 )
Methods: 10.43% ( 173 / 1658 )
Lines: 22.78% ( 2252 / 9887 )
Branches: 12.3% ( 187 / 1520 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 52.62% ( 341 / 648 )
Methods: 50% ( 40 / 80 )
Lines: 56.85% ( 282 / 496 )
Branches: 26.39% ( 19 / 72 )

@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 76.94% ( 564 / 733 )
Methods: 71.59% ( 63 / 88 )
Lines: 78.75% ( 493 / 626 )
Branches: 42.11% ( 8 / 19 )

@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 55.08% ( 4064 / 7379 )
Methods: 51.98% ( 499 / 960 )
Lines: 59.83% ( 3298 / 5512 )
Branches: 29.44% ( 267 / 907 )

andrewsignori-aot
andrewsignori-aot approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the additional tests and research, looks good 👍

dheepak-aot
dheepak-aot reviewed Nov 17, 2023
View reviewed changes
devops/openshift/forms-deploy.yml
type: AverageValue
averageValue: "0.8"
type: Utilization
averageUtilization: 50
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it 50 for form ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of the load testing for forms, the value is deried as 50%. This is similar to the .8 as mentioned previously.

ann-aot
ann-aot approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dheepak-aot
dheepak-aot approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@guru-aot guru-aot merged commit 34348af into main Nov 17, 2023
@guru-aot guru-aot deleted the #2383_Horizontal_Autoscaler_Bug branch November 17, 2023 23:28
andrepestana-aot
andrepestana-aot reviewed Nov 18, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepestana-aot andrepestana-aot andrepestana-aot left review comments

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@cditcher cditcher Awaiting requested review from cditcher

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@guru-aot guru-aot

Labels
Devops Devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guru-aot @dheepak-aot @andrewsignori-aot @ann-aot @andrepestana-aot