Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2510 - e-Cert Implementation for Individual Student Processing - Migrations and Entity Models Added #2513

Merged
merged 3 commits into from
Nov 17, 2023
Merged

#2510 - e-Cert Implementation for Individual Student Processing - Migrations and Entity Models Added #2513

merged 3 commits into from
Nov 17, 2023

Conversation

andrewsignori-aot
Copy link
Collaborator

Added the DB migrations needed for the e-Cert process changes.

  • New Ready to send status type for the enum DisbursementScheduleStatus.
  • New column ready_to_send_date in table sims.disbursement_schedules.

@andrewsignori-aot andrewsignori-aot added Queue Consumers DB DB migration involved labels Nov 17, 2023
@andrewsignori-aot andrewsignori-aot self-assigned this Nov 17, 2023
@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review November 17, 2023 02:15
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 20% ( 2613 / 13066 )
Methods: 10.43% ( 173 / 1658 )
Lines: 22.79% ( 2253 / 9888 )
Branches: 12.3% ( 187 / 1520 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 52.62% ( 341 / 648 )
Methods: 50% ( 40 / 80 )
Lines: 56.85% ( 282 / 496 )
Branches: 26.39% ( 19 / 72 )

@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 76.94% ( 564 / 733 )
Methods: 71.59% ( 63 / 88 )
Lines: 78.75% ( 493 / 626 )
Branches: 42.11% ( 8 / 19 )

@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 55.08% ( 4064 / 7379 )
Methods: 51.98% ( 499 / 960 )
Lines: 59.83% ( 3298 / 5512 )
Branches: 29.44% ( 267 / 907 )

ann-aot
ann-aot approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

guru-aot
guru-aot approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, nice work @andrewsignori-aot

andrepestana-aot
andrepestana-aot approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

dheepak-aot
dheepak-aot approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@andrewsignori-aot andrewsignori-aot merged commit 4a192ea into main Nov 17, 2023
@andrewsignori-aot andrewsignori-aot deleted the feature/#2510-e-cert-individual-student-processing branch November 17, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheepak-aot dheepak-aot dheepak-aot approved these changes

@guru-aot guru-aot guru-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

@andrepestana-aot andrepestana-aot andrepestana-aot approved these changes

@cditcher cditcher Awaiting requested review from cditcher

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

Assignees

@andrewsignori-aot andrewsignori-aot

Labels
DB DB migration involved Queue Consumers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewsignori-aot @dheepak-aot @guru-aot @ann-aot @andrepestana-aot